Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve opendialogurl configuration to be extensible #27863

Closed
wants to merge 10 commits into from
Original file line number Diff line number Diff line change
Expand Up @@ -31,35 +31,43 @@ class Image extends Media
*/
private $fileSize;

/**
* @var OpednDialogUrl
*/
private $openDialogUrl;

/**
* @param ContextInterface $context
* @param StoreManagerInterface $storeManager
* @param Size $fileSize
* @param OpenDialogUrl $openDialogUrl
* @param UiComponentInterface[] $components
* @param array $data
*/
public function __construct(
ContextInterface $context,
StoreManagerInterface $storeManager,
Size $fileSize,
OpenDialogUrl $openDialogUrl,
array $components = [],
array $data = []
) {
$this->storeManager = $storeManager;
$this->fileSize = $fileSize;
$this->openDialogUrl = $openDialogUrl;
parent::__construct($context, $components, $data);
}

/**
* {@inheritdoc}
* @inheritdoc
*/
public function getComponentName()
{
return static::NAME;
}

/**
* {@inheritdoc}
* @inheritdoc
*/
public function prepare()
{
Expand All @@ -75,7 +83,10 @@ public function prepare()
'config' => [
'maxFileSize' => $maxFileSize,
'mediaGallery' => [
'openDialogUrl' => $this->getContext()->getUrl('cms/wysiwyg_images/index', ['_secure' => true]),
'openDialogUrl' => $this->getContext()->getUrl(
$this->openDialogUrl->get(),
['_secure' => true]
),
'openDialogTitle' => $this->getConfiguration()['openDialogTitle'] ?? __('Insert Images...'),
'initialOpenSubpath' => $this->getConfiguration()['initialMediaGalleryOpenSubpath'],
'storeId' => $this->storeManager->getStore()->getId(),
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

declare(strict_types=1);

namespace Magento\Ui\Component\Form\Element\DataType\Media;

/**
* Basic configuration for OdenDialogUrl
*/
class OpenDialogUrl
{
private const DEFAULT_OPEN_DIALOG_URL = 'cms/wysiwyg_images/index';

/**
* @var string
*/
private $openDialogUrl;

/**
* @param string $url
*/
public function __construct(string $url = null)
{
$this->openDialogUrl = $url ?? self::DEFAULT_OPEN_DIALOG_URL;
}

/**
* Returns open dialog url for media browser
*
* @return string
*/
public function get(): string
{
return $this->openDialogUrl;
}
}