magento/magneto2#27570: fixed issue withsue with store id for cash on…

[ledian-hymetllari]

Description (*)

Fixed the issue with store view for cash and delivery method

Fixed Issues (if relevant)

#27570

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ledian-hymetllari. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[nuzil]

Hi @ledian-hymetllari

1. Can you please check failed tests?
2. Can you please cover this fix with additional test?

[VladimirZaets]

Hi @ledian-hymetllari. Thanks for collaboration. Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.

[ledian-hymetllari]

@VladimirZaets can you help me to fix these code tests please?

[VladimirZaets]

@magento run all tests

[VladimirZaets]

@ledian-hymetllari of course, I rerun tests to see what happens with them. What problem do you need?

[ledian-hymetllari]

@VladimirZaets is taking a look into this, as this is not failing due to my changes.

[ledian-hymetllari]

@VladimirZaets any info about this one please?

[magento-engcom-team]

Hi @nuzil, thank you for the review.
ENGCOM-7639 has been created to process this Pull Request

[engcom-Alfa]

Hi @nuzil What is the current status of this PR?
Thanks!

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-7639 has been created to process this Pull Request

[nuzil]

@swnsma thanks for catch it. Super strange that I do not getting any emails when new comments are appearing

[magento-engcom-team]

Hi @nuzil, thank you for the review.
ENGCOM-7639 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Preconditions:

Magento multi-store setup (Main Website Store, Second Website Store)
'Cache on delivery' payment method is enabled

Manual testing scenario:

1. Go to Admin->Stores -> Config -> Sales Methods -> Payment Methods -> Cache On Delivery and Change 'Cache on Delivery' method title in the scope of Second Website configurations;
   

2. Place the Order with 'cache on delivery' in the scope of Second Website Store.

3. Open order details in Admin Panel

Before: ✖️ The Payment Method name is being used from Default Store scope

After: ✔️ The Payment Method name is being used from Order Store scope

[m2-assistant]

Hi @ledian-hymetllari, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.