Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#27091 Removed array print while setup upgrade #27567

Merged
merged 6 commits into from
Jun 24, 2020
Merged

#27091 Removed array print while setup upgrade #27567

merged 6 commits into from
Jun 24, 2020

Conversation

srsathish92
Copy link
Contributor

@srsathish92 srsathish92 commented Apr 3, 2020 •
edited by engcom-Echo
Loading

Description (*)

This PR helps to remove array print while setup upgrade & installation.

Fixed Issues (if relevant)

  1. fixes Magento 2.3.4 array print while setup upgrade #27091

Manual testing scenarios (*)

  1. php bin/magento s:up
  2. we shouldn't see printed array content for caches (enabling/disabling)
    removed-print-array
  3. Check unit test by vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist setup/src/Magento/Setup/Test/Unit/Model/InstallerTest.php

Questions or comments

If any please let me know your feedback

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 3, 2020

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@srsathish92 srsathish92 requested a review from kalpmehta April 4, 2020 17:01
aleron75
aleron75 previously approved these changes Apr 5, 2020
View reviewed changes
@ghost ghost assigned aleron75 Apr 5, 2020
@aleron75 aleron75 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup Progress: pending review and removed Progress: ready for testing labels Apr 5, 2020
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-7265 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Apr 8, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Run in console: php bin/magento setup:upgrade

Before:
arraybefore

After:
Screenshot from 2020-04-08 13-46-52

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo engcom-Echo requested a review from slavvka May 15, 2020 13:05
@slavvka slavvka removed the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label May 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-7265 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Run in console: php bin/magento setup:upgrade

Before: ✖️
screenshot_17

After: ✔️
screenshot_18

@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label May 21, 2020
@engcom-Echo
Merge branch '2.4-develop' of http://github.com/magento/magento2 into…
075f997 
… bug/27091-remove-array-print

� Conflicts:
�	setup/src/Magento/Setup/Test/Unit/Model/InstallerTest.php
@engcom-Echo
resolved conflict
479166e
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 17, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Jun 24, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jun 24, 2020
@slavvka
ENGCOM-7265: #27091 Removed array print while setup upgrade #27567
6382421
@magento-engcom-team magento-engcom-team merged commit 758a51b into magento:2.4-develop Jun 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 24, 2020

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavvka slavvka slavvka approved these changes

@aleron75 aleron75 aleron75 left review comments

@kalpmehta kalpmehta Awaiting requested review from kalpmehta

Assignees

@aleron75 aleron75

@slavvka slavvka

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup Component: Setup Event: Global-Contribution-Day Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

Magento 2.3.4 array print while setup upgrade
8 participants
@srsathish92 @magento-engcom-team @engcom-Alfa @engcom-Echo @aleron75 @slavvka @ihor-sviziev @VladimirZaets