Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve openDialog method initialization #27566

Merged
merged 28 commits into from
Apr 22, 2020
Merged

Improve openDialog method initialization #27566

merged 28 commits into from
Apr 22, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Apr 3, 2020 •
edited by engcom-Golf
Loading

Description (*)

Related Pull Requests

magento/magento2-page-builder#450
magento/adobe-stock-integration#1186

Dependent PRs

Fixed Issues (if relevant)

  1. Loader stays over the media gallery if it was opened second time from different control on the same page adobe-stock-integration#935 : Loader stays over the media gallery if it was opened second time from different control on the same page

Manual testing scenarios (*)

Preconditions (*)

  1. Install Magento and Adobe Stock Integration See documentation

Steps to reproduce (*)

  1. Login to Admin panel
  2. Open Media Gallery (i.e. Catalog -> Category -> expand Content -> Select from Gallery button)
  3. Close the Media Gallery
  4. Open the Media Gallery using different entry point on the same page (i.e. WYSIWYG)

Expected result (*)
Media Gallery is loaded

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 3, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

kandy
kandy reviewed Apr 3, 2020
View reviewed changes
lib/web/mage/adminhtml/browser.js Outdated
* @param {*} title
* @param {Object} options
*/
openDialogNewMediaGallery: function (url, width, height, title, options) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "new" in the name is bad practice. Please use words that describe behavior

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask you to change other places that have "new", like is_new media_gallery?

@ghost ghost assigned kandy Apr 3, 2020
@Nazar65 Nazar65 mentioned this pull request Apr 3, 2020
Closed
@Nazar65
Copy link
Member Author

Nazar65 commented Apr 3, 2020

@kandy done ✔️

@ghost ghost assigned hws47a Apr 4, 2020
@hws47a
Copy link
Contributor

hws47a commented Apr 4, 2020

Hi @Nazar65,

Thank you for contribution.
Just some small comments from my side.

Stanislav Idolov added 3 commits April 6, 2020 16:20
magento/adobe-stock-integration#935 : Loader stays over the media gal…
c839ecc 
…lery if it was opened second time from different control on the same page
magento/adobe-stock-integration#935 : Loader stays over the media gal…
e5e23a8 
…lery if it was opened second time from different control on the same page
#27566: Do not re-load the gallery app, just content
7ba5410
sidolov pushed a commit to sidolov/adobe-stock-integration that referenced this pull request Apr 7, 2020
magento/magento2#27566: Do not re-load the gallery app, just content
5a02d60
@sidolov sidolov mentioned this pull request Apr 9, 2020
Closed
@chalov-anton chalov-anton self-assigned this Apr 9, 2020
@Nazar65 Nazar65 added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 9, 2020
@Nazar65 Nazar65 changed the title Add suport to the new media gallery Improve openDialog method initialization Apr 9, 2020
@engcom-Golf
Copy link
Contributor

@magento run all tests

@Nazar65 Nazar65 mentioned this pull request Apr 16, 2020
Closed
4 tasks
@engcom-Golf engcom-Golf mentioned this pull request Apr 16, 2020
Closed
4 tasks
@Nazar65 Nazar65 mentioned this pull request Apr 16, 2020
Merged
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7295 has been created to process this Pull Request

@Nazar65
Copy link
Member Author

Nazar65 commented Apr 17, 2020

Failed functional tests B2B not related to the changes in this pr

@engcom-Golf
Copy link
Contributor

@magento run all tests

@lenaorobei lenaorobei mentioned this pull request Apr 20, 2020
Merged
4 tasks
magento-engcom-team pushed a commit that referenced this pull request Apr 22, 2020
@slavvka
ENGCOM-7295: Improve openDialog method initialization #27566
9090ab8
@magento-engcom-team magento-engcom-team merged commit c477172 into magento:2.4-develop Apr 22, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 22, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kandy kandy kandy left review comments

@VladimirZaets VladimirZaets VladimirZaets left review comments

@omiroshnichenko omiroshnichenko omiroshnichenko left review comments

@hws47a hws47a hws47a requested changes

@slavvka slavvka slavvka requested changes

@sivaschenko sivaschenko sivaschenko approved these changes

@lenaorobei lenaorobei lenaorobei approved these changes

@sidolov sidolov Awaiting requested review from sidolov

Assignees

@kandy kandy

@hws47a hws47a

@sivaschenko sivaschenko

@VladimirZaets VladimirZaets

@slavvka slavvka

@lenaorobei lenaorobei

@omiroshnichenko omiroshnichenko

@chalov-anton chalov-anton

Labels
Area: Frontend Area: Lib/Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Cms Component: Data Component: Tinymce Component: Ui Event: Global-Contribution-Day Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.