Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue 27051: Saving an attribute with backend_type static #27369

Merged
merged 11 commits into from
Jun 25, 2020
Merged

Fixed issue 27051: Saving an attribute with backend_type static #27369

merged 11 commits into from
Jun 25, 2020

Conversation

jiten-patel
Copy link
Contributor

@jiten-patel jiten-patel commented Mar 20, 2020

Description (*)

Fixed 'frontend_class' field issue while saving an attribute with backend_type 'static'.

Related Pull Requests

Fixed Issues (if relevant)

  1. fixes Saving an attribute with backend_type 'static' will remove the content of the 'frontend_class' field. #27051: Saving an attribute with backend_type 'static' will remove the content of the 'frontend_class' field.

Manual testing scenarios (*)

  1. Navigate to Stores > Attributes > Product
  2. Click an attribute with backend_type = static. Example: sku or category_ids
  3. On the attribute edit page, you can either modify some fields or not modify any field at all.
  4. Click "Save and continue edit".
  5. Open Database and select eav_attribute table
  6. Check frontend_class for that attribute

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 20, 2020

Hi @jitenp886613. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@jiten-patel
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @jiten-patel. Thank you for your request. I'm working on Magento instance for you

@edenduong edenduong self-assigned this Mar 21, 2020
@edenduong edenduong added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix labels Mar 21, 2020
Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jiten-patel, could you please cover your changes by Unit/Integration Tests? Thank you very much !

@engcom-Echo engcom-Echo self-assigned this Apr 27, 2020
@engcom-Echo
Copy link
Contributor

I will take care of test coverage.

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo engcom-Echo requested a review from edenduong April 28, 2020 10:30
@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@ghost ghost removed the Progress: needs update label May 4, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Echo engcom-Echo requested a review from slavvka May 18, 2020 18:54
@magento-engcom-team
Copy link
Contributor

Hi @edenduong, thank you for the review.
ENGCOM-7511 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@jiten-patel thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Navigate to Stores > Attributes > Product;
  2. Click an attribute with backend_type = static. Example: SKU;
  3. On the attribute edit page, you can either modify some fields or not modify any field at all;
  4. Click "Save";
  5. Open Database and select eav_attribute table;
  6. Check frontend_class for that attribute;

Before: frontend_class has value NULL

screenshot_26

After: ✔️ frontend_class has the same value as before saving

screenshot_25

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label May 26, 2020
@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 19, 2020
@magento-engcom-team magento-engcom-team merged commit 4e0c02a into magento:2.4-develop Jun 25, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 25, 2020

Hi @jiten-patel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Catalog Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Saving an attribute with backend_type 'static' will remove the content of the 'frontend_class' field.
7 participants