Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYPO: Fix annoying typo in Quantity word #27281

Merged
merged 1 commit into from
Mar 17, 2020
Merged

TYPO: Fix annoying typo in Quantity word #27281

merged 1 commit into from
Mar 17, 2020

Conversation

lbajsarowicz
Copy link
Contributor

Description (*)

Annoying to refer using stepKey with typo :-)

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@eduard13 eduard13 self-assigned this Mar 13, 2020
@eduard13 eduard13 added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup labels Mar 13, 2020
eduard13
eduard13 approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree 👍

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-7093 has been created to process this Pull Request

@engcom-Bravo engcom-Bravo self-assigned this Mar 13, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Mar 13, 2020
@engcom-Charlie
Copy link
Contributor

Failed functional tests not related to the changes in this PR

magento-engcom-team pushed a commit that referenced this pull request Mar 17, 2020
@slavvka
ENGCOM-7093: TYPO: Fix annoying typo in Quantity word #27281
faab855
@magento-engcom-team magento-engcom-team merged commit fc12304 into magento:2.4-develop Mar 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 17, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

Assignees

@eduard13 eduard13

@engcom-Bravo engcom-Bravo

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: ConfigurableProduct Component: Sales Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lbajsarowicz @magento-engcom-team @engcom-Bravo @engcom-Charlie @eduard13