Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF: Rename and rewrite Test that fake expired session #27277

Merged
merged 2 commits into from
Mar 17, 2020
Merged

MFTF: Rename and rewrite Test that fake expired session #27277

merged 2 commits into from
Mar 17, 2020

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Mar 13, 2020 •
edited
Loading

Description (*)

Add to cart with Expired session:

  • Added information about avoiding excessive Action Groups
  • Extracted atomic action groups with minimal features
  • Rewritten StorefrontAddProductToCartWithExpiredSessionTest.xml

In future I'd like to deassemble huge ActionGroup that adds to cart, but it's backwards-incompatible, so it's not the easiest task in backlog.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@lbajsarowicz
Add to cart with Expired session:
657ff0f 
- Added information about avoiding excessive Action Groups
- Extracted atomic action groups with minimal features
- Rewritten StorefrontAddProductToCartWithExpiredSessionTest.xml
@m2-assistant
Copy link

m2-assistant bot commented Mar 13, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

lbajsarowicz
lbajsarowicz commented Mar 13, 2020
View reviewed changes
app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontOpenProductEntityPageActionGroup.xml
Comment on lines +14 to +18
<arguments>
<argument name="product" type="entity"/>
</arguments>

<amOnPage url="{{StorefrontProductPage.url(product.custom_attributes[url_key])}}" stepKey="goToProductPage"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was added to load the Product URL properly using StorefrontProductPage.url and url_key instead of Product's name 🤦‍♂️

@ghost ghost assigned lbajsarowicz Mar 13, 2020
@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Award: MFTF test coverage labels Mar 13, 2020
@ghost ghost assigned dmytro-ch Mar 13, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7091 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Mar 13, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Echo engcom-Echo self-assigned this Mar 13, 2020
@engcom-Echo
Copy link
Contributor

@magento all run tests

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@ghost ghost added the Progress: accept label Mar 16, 2020
magento-engcom-team pushed a commit that referenced this pull request Mar 17, 2020
@slavvka
ENGCOM-7091: MFTF: Rename and rewrite Test that fake expired session #…
5aaacbd 
…27277
@magento-engcom-team magento-engcom-team merged commit 09a56b9 into magento:2.4-develop Mar 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 17, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Award: MFTF test coverage Component: Catalog Component: Checkout Component: Customer Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lbajsarowicz @magento-engcom-team @engcom-Alfa @engcom-Echo @dmytro-ch