Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Italy States #27116

Merged
merged 5 commits into from
Mar 21, 2020
Merged

Add Italy States #27116

merged 5 commits into from
Mar 21, 2020

Conversation

WaPoNe
Copy link
Contributor

@WaPoNe WaPoNe commented Mar 1, 2020

Description (*)

Add Italy States

Related Pull Requests

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Michele Fantetti and others added 2 commits March 1, 2020 19:55
@m2-assistant
Copy link

m2-assistant bot commented Mar 1, 2020

Hi @WaPoNe. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch self-assigned this Mar 3, 2020
@dmytro-ch dmytro-ch added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Mar 3, 2020
dmytro-ch
dmytro-ch requested changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @WaPoNe, thank you for your contribution.
Due to Magento Definition of Done the changes should be covered by tests. Could you please cover your fix by a functional test and also fix the static test failure?

Thank you!

@engcom-Echo engcom-Echo self-assigned this Mar 4, 2020
@engcom-Echo
Copy link
Contributor

I will take care of test coverage.

@WaPoNe
Copy link
Contributor Author

WaPoNe commented Mar 17, 2020

Thanks @engcom-Echo
Tell me how I can help you.
If you want, I can prepare the functional and static tests following your suggestions.

@engcom-Echo engcom-Echo requested a review from dmytro-ch March 17, 2020 10:51
@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Progress: needs update Award: category of expertise and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Progress: ready for testing labels Mar 17, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7113 has been created to process this Pull Request

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@engcom-Alfa engcom-Alfa self-assigned this Mar 18, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

magento-engcom-team pushed a commit that referenced this pull request Mar 21, 2020
@slavvka
ENGCOM-7113: Add Italy States #27116
92508ae
@magento-engcom-team magento-engcom-team merged commit 30bebf9 into magento:2.4-develop Mar 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 21, 2020

Hi @WaPoNe, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Component: Directory Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WaPoNe @engcom-Echo @magento-engcom-team @engcom-Alfa @dmytro-ch @eduard13