remove script tag #25418

torhoehn · 2019-10-31T20:31:50Z

Description (*)

Removed script tag, but tooltip still opens correctly.

Fixed Issues (if relevant)

Fixes Product AdditionalOptions "Read more" dots being escaped on invoice/shipment overview pages #25050 : Product AdditionalOptions "Read more" dots being escaping on invoice/shipment overview pages

Manual testing scenarios (*)

Create a product that includes an additionalOption value that is over 55 characters
Place order for product
View invoice for order in customer dashboard

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2019-10-31T20:31:53Z

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

kalpmehta · 2019-11-01T03:11:46Z

@magento give me test instance

magento-engcom-team · 2019-11-01T03:11:48Z

Hi @kalpmehta. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-11-01T03:12:25Z

Hi @kalpmehta, here is your new Magento instance.
Admin access: https://pr-25418.instances.magento-community.engineering/admin
Login: admin Password: 123123q

magento-engcom-team · 2019-11-01T03:28:43Z

Hi @kalpmehta, thank you for the review.
ENGCOM-6223 has been created to process this Pull Request
✳️ @kalpmehta, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

dmytro-ch

Hi @torhoehn,
could you please make sure the tooltip is also initialized for order items renderer as well for shipment, invoice and credit memo.
So we would get the same behavior for all tabs.

E.g.
Shipment Items: Magento/Sales/view/frontend/templates/order/shipment/items/renderer/default.phtml
Order Items: Magento/Sales/view/frontend/templates/order/items/renderer/default.phtml

torhoehn · 2019-11-04T20:31:05Z

@dmytro-ch You're absolutely right and I added it.

dmytro-ch · 2019-11-06T09:23:08Z

@torhoehn, great, thank you!

torhoehn · 2019-11-07T10:00:50Z

@engcom-Bravo This expected behaviour, because until now the fix #25393 is not inside of this branch. If you want I could merge 2.3-develop into this feature, so you we can see if everything works as it should.

engcom-Bravo · 2019-11-07T10:09:07Z

Ok @torhoehn, please take care from Your side as much as You can on that all the fixes will persist in the develop. Thank You. ✔️ QA Passed.

torhoehn · 2019-11-07T14:20:29Z

@magento give me test instance

magento-engcom-team · 2019-11-07T14:20:32Z

Hi @torhoehn. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-11-07T14:21:21Z

Hi @torhoehn, here is your new Magento instance.
Admin access: https://pr-25418.instances.magento-community.engineering/admin
Login: admin Password: 123123q

torhoehn · 2019-11-07T14:40:16Z

@engcom-Bravo Everything works as expected now!

magento-engcom-team · 2019-11-08T07:51:32Z

Hi @dmytro-ch, thank you for the review.
ENGCOM-6223 has been created to process this Pull Request

m2-assistant · 2019-11-14T14:23:51Z

Hi @torhoehn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

oleksii-lisovyi · 2020-08-27T14:20:49Z

app/code/Magento/Sales/view/frontend/templates/order/creditmemo/items/renderer/default.phtml

@@ -17,7 +17,7 @@
                <?php if (!$block->getPrintStatus()) : ?>
                    <?php $_formatedOptionValue = $block->getFormatedOptionValue($_option) ?>
                    <dd<?= (isset($_formatedOptionValue['full_view']) ? ' class="tooltip wrapper"' : '') ?>>
-                        <?= $block->escapeHtml($_formatedOptionValue['value']) ?>
+                        <?= $block->escapeHtml($_formatedOptionValue['value'], ['a', 'img']) ?>


img tag is not allowed in the html Escaper class:
https://github.com/magento/magento2/blob/2.4-develop/lib/internal/Magento/Framework/Escaper.php#L40

This generates an error The following tag(s) are not allowed: img when go to the Order page in My Account
The line in the Escaper:
https://github.com/magento/magento2/blob/2.4-develop/lib/internal/Magento/Framework/Escaper.php#L457

Probably removing the img from allowed tags passed as the second parameter should be enough.

I created pull request, that fixed critical error
#29863

…: img Details: magento#25418 (comment)

remove script tag

e422942

torhoehn requested a review from YevSent as a code owner October 31, 2019 20:31

magento-engcom-team added Component: Sales Release Line: 2.3 Partner: Basecom partners-contribution Pull Request is created by Magento Partner labels Oct 31, 2019

torhoehn added the Squashtoberfest 2019 label Oct 31, 2019

kalpmehta self-assigned this Nov 1, 2019

kalpmehta approved these changes Nov 1, 2019

View reviewed changes

ghost added the Progress: ready for testing label Nov 1, 2019

kalpmehta added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Nov 1, 2019

dmytro-ch requested changes Nov 1, 2019

View reviewed changes

ghost assigned dmytro-ch Nov 1, 2019

ghost added Progress: needs update and removed Progress: ready for testing labels Nov 1, 2019

initialize tooltip for order items

4b432f8

fix functional tests

d4cae50

torhoehn requested a review from dmytro-ch November 5, 2019 14:08

dmytro-ch approved these changes Nov 6, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Nov 6, 2019

magento-engcom-team added the Area: Frontend label Nov 6, 2019

ghost added the Progress: needs update label Nov 7, 2019

ghost added Progress: testing in progress Progress: extended testing Progress: accept and removed Progress: needs update Progress: testing in progress Progress: extended testing labels Nov 7, 2019

Merge branch '2.3-develop' into feature/additional-product-options

6e36d5e

magento-engcom-team assigned VladimirZaets Nov 7, 2019

dmytro-ch approved these changes Nov 8, 2019

View reviewed changes

VladimirZaets mentioned this pull request Nov 14, 2019

Product AdditionalOptions "Read more" dots being escaped on invoice/shipment overview pages #25050

Closed

magento-engcom-team pushed a commit that referenced this pull request Nov 14, 2019

ENGCOM-6223: remove script tag #25418

5aa7262

magento-engcom-team merged commit 6e36d5e into magento:2.3-develop Nov 14, 2019

magento-engcom-team added this to the Release: 2.3.5 milestone Nov 14, 2019

torhoehn deleted the feature/additional-product-options branch November 14, 2019 14:34

VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Nov 22, 2019

oleksii-lisovyi reviewed Aug 27, 2020

View reviewed changes

themystery404 pushed a commit to themystery404/magento2 that referenced this pull request Sep 2, 2020

Fixed issue with critical error: The following tag(s) are not allowed…

798e61f

…: img Details: magento#25418 (comment)

themystery404 mentioned this pull request Sep 2, 2020

Fixed critical error: The following tag(s) are not allowed: img #29863

Merged

5 tasks

m2-assistant bot mentioned this pull request Sep 9, 2020

[Issue] Fixed critical error: The following tag(s) are not allowed: img #29958

Closed

adamstapley mentioned this pull request May 10, 2021

Text Area for Customizable Options shows line break html<br/> on the front end in cart area if a user enters more than 55 characters #32977

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove script tag #25418

remove script tag #25418

torhoehn commented Oct 31, 2019 •

edited by ihor-sviziev

Loading

m2-assistant bot commented Oct 31, 2019

kalpmehta commented Nov 1, 2019

magento-engcom-team commented Nov 1, 2019

magento-engcom-team commented Nov 1, 2019

magento-engcom-team commented Nov 1, 2019

dmytro-ch left a comment

torhoehn commented Nov 4, 2019

dmytro-ch commented Nov 6, 2019

torhoehn commented Nov 7, 2019

engcom-Bravo commented Nov 7, 2019

torhoehn commented Nov 7, 2019

magento-engcom-team commented Nov 7, 2019

magento-engcom-team commented Nov 7, 2019

torhoehn commented Nov 7, 2019

magento-engcom-team commented Nov 8, 2019

m2-assistant bot commented Nov 14, 2019

oleksii-lisovyi Aug 27, 2020

themystery404 Sep 2, 2020

remove script tag #25418

remove script tag #25418

Conversation

torhoehn commented Oct 31, 2019 • edited by ihor-sviziev Loading

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Oct 31, 2019

kalpmehta commented Nov 1, 2019

magento-engcom-team commented Nov 1, 2019

magento-engcom-team commented Nov 1, 2019

magento-engcom-team commented Nov 1, 2019

dmytro-ch left a comment

Choose a reason for hiding this comment

torhoehn commented Nov 4, 2019

dmytro-ch commented Nov 6, 2019

torhoehn commented Nov 7, 2019

engcom-Bravo commented Nov 7, 2019

torhoehn commented Nov 7, 2019

magento-engcom-team commented Nov 7, 2019

magento-engcom-team commented Nov 7, 2019

torhoehn commented Nov 7, 2019

magento-engcom-team commented Nov 8, 2019

m2-assistant bot commented Nov 14, 2019

oleksii-lisovyi Aug 27, 2020

Choose a reason for hiding this comment

themystery404 Sep 2, 2020

Choose a reason for hiding this comment

torhoehn commented Oct 31, 2019 •

edited by ihor-sviziev

Loading