Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless semicolons #24872

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Remove useless semicolons #24872

merged 1 commit into from
Oct 8, 2019

Conversation

carusogabriel
Copy link
Contributor

Description (*)

These ones were not found via the no_empty_statement from php-cs-fixer.

Fixed Issues (if relevant)

None.

Manual testing scenarios (*)

Not necessary

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

These ones were not found via the `no_empty_statement` from `php-cs-fixer`.
@m2-assistant
Copy link

m2-assistant bot commented Oct 5, 2019

Hi @carusogabriel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned aleron75 Oct 6, 2019
@aleron75 aleron75 added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Progress: ready for testing labels Oct 6, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6017 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@carusogabriel thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this Oct 7, 2019
@engcom-Alfa
Copy link
Contributor

QA not applicable

@m2-assistant
Copy link

m2-assistant bot commented Oct 8, 2019

Hi @carusogabriel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 8, 2019
@carusogabriel carusogabriel deleted the style/remove-useless-semicolons branch October 8, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants