Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue #24779 #24845

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Oct 3, 2019

Description

Resolved Issue #24779

  • Added a rel="noopener" attribute to the anchor tag prevents freezing of parent tabs

Fixed Issues

Manual testing scenarios

  1. In Admin panel, navigate to Sales -> Orders
  2. Open an order
  3. Click Customer View in the profile menu on top right
  4. Create a test customer in the tab that was opened automatically (do not close previous tab)
  5. Place an order and click print.
  6. You should see the print preview in new tab (do not close previous tab)

All previously opened tabs are responsive and active now.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@drpayyne drpayyne requested a review from paliarush as a code owner October 3, 2019 17:28
@m2-assistant
Copy link

m2-assistant bot commented Oct 3, 2019

Hi @drpayyne. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@drpayyne
Copy link
Contributor Author

drpayyne commented Oct 3, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @drpayyne. Thank you for your request. I'm working on Magento instance for you

@drpayyne
Copy link
Contributor Author

drpayyne commented Oct 4, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @drpayyne. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @drpayyne, here is your new Magento instance.
Admin access: https://pr-24845.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost ghost assigned aleron75 Oct 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-5995 has been created to process this Pull Request
✳️ @aleron75, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

Hi @drpayyne

The same problem is encountered in "Print Order", "Print Invoice", "Print Shipment" and "Print Refund", "Print All Invoices", "Print All Shipments", "Print All Refunds".
@drpayyne Could you, please, fix it in scope of this PR?

Thanks!

@drpayyne
Copy link
Contributor Author

drpayyne commented Oct 4, 2019

Hello @engcom-Alfa, fixed your requested changes. Made all the code consistent too! Thank you.

@ghost
Copy link

ghost commented Oct 4, 2019

@drpayyne unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5995 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Oct 8, 2019

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants