Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistent grammar #24835

Merged

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Oct 3, 2019

Description

Fixed inconsistent grammar of Newsletter Templates title in menu.
All menu titles are in plural whereas Newsletter Templates title is in singular form. The title of the page once the menu item is clicked, is also in plural.

Changed Newsletter Template -> Newsletter Templates under Marketing -> Communications

Manual testing scenarios

  1. Open Admin panel in 2.3-develop branch
  2. Verify change mentioned above in menu title

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 3, 2019

Hi @drpayyne. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@drpayyne
Copy link
Contributor Author

drpayyne commented Oct 3, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @drpayyne. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @drpayyne, here is your new Magento instance.
Admin access: https://pr-24835.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@kalpmehta kalpmehta self-assigned this Oct 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-5991 has been created to process this Pull Request
✳️ @kalpmehta, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@kalpmehta kalpmehta added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Oct 3, 2019
@engcom-Alfa engcom-Alfa self-assigned this Oct 3, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Oct 3, 2019
@magento-engcom-team magento-engcom-team merged commit 42e4103 into magento:2.3-develop Oct 8, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 8, 2019

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants