Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url for back button on multishipping new shipping address #24827

Merged
merged 5 commits into from
Oct 8, 2019

Conversation

MaxSouza
Copy link
Contributor

@MaxSouza MaxSouza commented Oct 2, 2019

Description (*)

Fix back button url on multishipping new shipping address

Fixed Issues (if relevant)

  1. Magento/Multishipping: Setting wrong back url on creation New Customer Shipping Address Page #24701 : Magento/Multishipping: Setting wrong back url on creation New Customer Shipping Address Page

Manual testing scenarios (*)

  1. Create new customer (customer should not have addresses).
  2. Add some product to cart.
  3. Open cart.
  4. Click "Check Out with Multiple Addresses".
  5. Check back button url that is hidden.

Questions or comments

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@MaxSouza MaxSouza requested a review from YevSent as a code owner October 2, 2019 13:58
@m2-assistant
Copy link

m2-assistant bot commented Oct 2, 2019

Hi @MaxSouza. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@MaxSouza
Copy link
Contributor Author

MaxSouza commented Oct 2, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @MaxSouza. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @MaxSouza, here is your new Magento instance.
Admin access: https://pr-24827.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost ghost assigned aleron75 Oct 3, 2019
@aleron75 aleron75 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Progress: ready for testing labels Oct 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-5993 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Oct 3, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Checked on Blank theme

Before:
after2

After:
after3

@m2-assistant
Copy link

m2-assistant bot commented Oct 8, 2019

Hi @MaxSouza, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants