Allow multiple conditions for expired quotes collection

[p-bystritsky]

Description (*)

This is a refactoring of #20777

With Magento\Sales\Cron\CleanExpiredQuotes::setExpireQuotesAdditionalFilterFields() assigning values directly to the attribute and getExpireQuotesAdditionalFilterFields() being protected isn't callable outside the class, hence unable to add more to the existing condition, rather they end up being replaced with the new ones.

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

EE code should also be adapted.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ghost]

@p-bystritsky unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

[sivaschenko]

@p-bystritsky can you please sign the CLA

[m2-assistant]

Hi @p-bystritsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[swnsma]

Hi @p-bystritsky,
Thank you for you review!
Lets discuss your solution under my comment in the code.

[swnsma]

Do you really believe that we need to have a separated class to collect the filters?
Or could we just add filters as array parameter to the app/code/Magento/Sales/Model/ResourceModel/Collection/ExpiredQuotesCollection.php ?
I can not come with real case when we need a new class.

[p-bystritsky]

Closing this PR due to creation of #24858.

[m2-assistant]

Hi @p-bystritsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.