Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix where massactions whould give table not found error #23451 #24258

Closed
wants to merge 1 commit into from

Conversation

joeriLock93
Copy link

Description:
Removed 'main_table' in idsSelect->columns() in getGridIdsJson()

Fixed issues:
#23451 Zend_Db_Select_Exception when accessing dynamic data such as blackbird/contentypes

Manual testing scenario:
See isuee #23451

  • Implement new grid Magento\Backend\Block\Widget\Grid (I know it's deprecated)
  • The gris MUST use an EAV collection type
  • Add following massaction block: Magento\Backend\Block\Widget\Grid\Massaction

@m2-assistant
Copy link

m2-assistant bot commented Aug 23, 2019

Hi @joeriLock93. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 23, 2019

CLA assistant check
All committers have signed the CLA.

@sidolov
Copy link
Contributor

sidolov commented Oct 4, 2019

@joeriLock93 I'm closing this PR as duplicate of #23452
Thank you for your collaboration!

@sidolov sidolov closed this Oct 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 4, 2019

Hi @joeriLock93, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants