Refactor: Improve mview code readability

[lbajsarowicz]

Description (*)

I found lib/internal/Magento/Framework/Mview/View.php code really annoying to debug / investigate, so that I changed some parts to be more readable, functional.

Fixed Issues (if relevant)

Irrelevant

Manual testing scenarios (*)

1. Set up your Magento instance to use On schedule reindex
2. Change product's data
3. Review the logs to confirm that there are no issues

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[ihor-sviziev]

Hi @aredridel,

Changes looks good to me. Let's wait once all tests will be executed, probably some changes still be required.
Once you finish fixing code style and other issues - please squash all your changes into single commit and force push them.

Thank you

[ihor-sviziev]

Looks like it could be replaced to $subscriptionInstance = $this->initSubscriptionInstance($subscriptionConfig);

[lbajsarowicz]

There's inconsistency with 'subscription_model' and 'subscriptionModel', however I'll try to handle that.

[lbajsarowicz]

OK. According to the

magento2/lib/internal/Magento/Framework/Mview/Config/Converter.php

Lines 89 to 93 in 15e3c07

	$data['subscriptions'][$name] = [
	'name' => $name,
	'column' => $column,
	'subscription_model' => $subscriptionModel
	];

- This should be subscription_model not subscriptionModel

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5291 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Delta]

✔️ QA Passed

[m2-assistant]

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.