Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Catalog] [MediaStorage] Fix watermark in media application #21338

Merged
merged 2 commits into from
Mar 4, 2019
Merged

[Catalog] [MediaStorage] Fix watermark in media application #21338

merged 2 commits into from
Mar 4, 2019

Conversation

progreg
Copy link
Contributor

@progreg progreg commented Feb 19, 2019

Description (*)

While media request Magento doesn't process watermarks. Also while catalog:images:resize watermarks are not processing for base catalog images. Watermark process was added in resize image function to fix media get request and console catalog images resize process.

Fixed Issues (if relevant)

  1. 2.3.0 Watermark not showing on images #21154: 2.3.0 Watermark not showing on images

Manual testing scenarios (*)

  • Create categories
  • Create products
  • Upload a watermark
  • Set image opacity to 10, image size to 40x50, image position to tile, and saved configuration.
  • Tap the Cache Management link in the system message. Then, refresh the invalid cache & catalog media cache

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @progreg. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@progreg
Copy link
Contributor Author

progreg commented Feb 20, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @progreg. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @progreg, here is your Magento instance.
Admin access: https://i-21338-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-4378 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 7190983 into magento:2.3-develop Mar 4, 2019
@ghost
Copy link

ghost commented Mar 4, 2019

Hi @progreg, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants