Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Adjust page-main container height for sticky footer; fixes #15118 #17809

Merged
merged 1 commit into from
Sep 4, 2018
Merged

[Forwardport] Adjust page-main container height for sticky footer; fixes #15118 #17809

merged 1 commit into from
Sep 4, 2018

Conversation

nmalevanec
Copy link
Contributor

Original Pull Request

#17006

Description

Adjusted page-main container height for sticky footer. Added fix for Blank and Luma themes

Fixed Issues

#15118 Footers do not snap to bottom of screen on mobile devices

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2878 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants