-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing - Responsive Layout on footer #16981
Fixing - Responsive Layout on footer #16981
Conversation
Hi @rodrigoobiassi. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@rodrigoobiassi thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Please check if PR #17006 fixes this for you and close as necessary. |
@rodrigoobiassi , please, check comment above and take a look at merge conflict. |
Hi @sidolov, I just made the requested change. Thanks. |
@rodrigoobiassi Are you sure this PR is still required. PR #17006 made changes to the responsive layout for mobile devices, namely it made the mobile screens behave the same way as the desktop screens with respect to the footers. i.e that if the page/content is shorter than the screen, then the footer snaps to the bottom whereas if the page/content is longer than the screen, then the footer is pushed to the bottom of the content, and not the bottom of the screen. It looks like this PR is in conflict with this resolution, i.e that it will cause the footer to always snap to the bottom of the screen regardless of the page/content size. This is not consistent with the desktop layout. |
Hi @rodrigoobiassi , please, read the comment from @gwharton , maybe the issue resolved and we can close this pr? |
Hi @rodrigoobiassi , I am closing this PR now due to inactivity. |
I was showing the platform to a prospective client and noticed this problem. Broken responsive layout.
1 -
2 -