-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve "Invalid country code" error message on tax import #16873
Improve "Invalid country code" error message on tax import #16873
Conversation
Hi @adampmoss. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @adampmoss. Thanks for the collaboration. You should add the translation for your phrase to [locale].cvs |
@adampmoss thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Done, and updated tests too. |
@adampmoss thanks. |
Hi @adampmoss. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
This change helps when importing tax CSVs by telling the user which country is responsible for the error being thrown. Without this it is a very annoying error to get and the user just has to guess.
Before:
After:
Manual testing scenarios
Create a tax import CSV with an inavlid country code, for example:
Then attempt to import the CSV by going to Magento Admin > System > Data Transfer > Import/Export Tax Rates
Contribution checklist