Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct use of object manager #16851

Conversation

AnshuMishra17
Copy link
Contributor

Description

Remove the direct use of object manager and loaded the dependency via constructor dependency injection.

Manual testing scenarios

  1. Unsubscribe the newsletter subscribers using the unsubscription mass action in admin.
  2. Deleted the newsletter subscribers using the delete mass action in admin.

@magento-engcom-team
Copy link
Contributor

Hi @AnshuMishra17. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2379 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit f047173 into magento:2.2-develop Jul 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @AnshuMishra17. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants