Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forwardport] Admin user auth controller refactor #16650

Conversation

AnshuMishra17
Copy link
Contributor

@AnshuMishra17 AnshuMishra17 commented Jul 9, 2018

Original Pull Request

#16560

Description
Refactor the code by removing the direct use of ObjectManager and includes the dependencies using Constructor Dependency Injection

Manual testing scenarios

  1. Created a new admin user
  2. Login and logout using new admin user
  3. Clicked on forgot password and provided new admin user email id.
  4. Clicked on reset password link in email.
  5. Created new password from reset password page.
  6. Login using new password.

@magento-engcom-team
Copy link
Contributor

Hi @AnshuMishra17. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@AnshuMishra17
Copy link
Contributor Author

@arnoudhgz I have created new PR for changes done under #16560

@AnshuMishra17 AnshuMishra17 requested a review from arnoudhgz July 9, 2018 13:31
@arnoudhgz
Copy link
Contributor

@AnshuMishra17 I think you are almost there, please solve the issues found with the Codacy and TravisCI automated checks.

At the moment the TravisCI check TEST_SUITE=integration INTEGRATION_INDEX=2 will fail because of a timeout. This is not resolvable at the moment I think.

The other checks you can probably resolve.

@AnshuMishra17
Copy link
Contributor Author

@arnoudhgz I can see following issues that I am not sure how to rectify.
It would be nice if you can take a look and guide me with correct steps to fix the issues.

  1. The property $_userFactory is not named in camelCase.
    How to change this?
  2. Avoid using static access to class '\Zend_Validate' in method 'execute'.
    What is the recommended way to fix this?
  3. Avoid excessively long variable names like $userCollectionFactory. Keep variable name length under 20.
    What should be the variable name here, according to Magento coding standards?

@ihor-sviziev
Copy link
Contributor

@AnshuMishra17 ping me in Slack, I'll help you to finalize both PRs.

@ihor-sviziev ihor-sviziev self-assigned this Jul 11, 2018
@ihor-sviziev ihor-sviziev changed the title Admin user auth controller refactor [forwardport] Admin user auth controller refactor Jul 11, 2018
@arnoudhgz arnoudhgz removed their request for review July 16, 2018 20:31
@ihor-sviziev ihor-sviziev self-requested a review July 20, 2018 06:12
@ihor-sviziev
Copy link
Contributor

Hi @AnshuMishra17,
Unfortunately due to mistake and not full list of changes from original PR @sidolov merged forwardport PR from another author #17140. Sorry for that.
I'm closing this PR as not relevant anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants