-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[forwardport] Admin user auth controller refactor #16650
[forwardport] Admin user auth controller refactor #16650
Conversation
Hi @AnshuMishra17. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@arnoudhgz I have created new PR for changes done under #16560 |
@AnshuMishra17 I think you are almost there, please solve the issues found with the Codacy and TravisCI automated checks. At the moment the TravisCI check The other checks you can probably resolve. |
@arnoudhgz I can see following issues that I am not sure how to rectify.
|
@AnshuMishra17 ping me in Slack, I'll help you to finalize both PRs. |
Hi @AnshuMishra17, |
Original Pull Request
#16560
Description
Refactor the code by removing the direct use of ObjectManager and includes the dependencies using Constructor Dependency Injection
Manual testing scenarios