Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.2] Fixed return type hinting in DocBlocks for Wishlist module #15854

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Wishlist/Block/Rss/EmailLink.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class EmailLink extends Link
protected $_template = 'rss/email.phtml';

/**
* @return string
* @return array
*/
protected function getLinkParams()
{
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Wishlist/Block/Rss/Link.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public function isRssAllowed()
}

/**
* @return string
* @return array
*/
protected function getLinkParams()
{
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Wishlist/Helper/Data.php
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ public function isAllowInCart()
/**
* Retrieve customer name
*
* @return string|void
* @return string|null
*/
public function getCustomerName()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public function __construct(Data $helper)
/**
* Add tax data to result
*
* @param \Magento\Checkout\CustomerData\Cart $subject
* @param \Magento\Catalog\Ui\DataProvider\Product\Listing\DataProvider $subject
* @param array $result
* @return array
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
Expand Down