Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed set template syntax issue #15398

Merged

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented May 21, 2018

Description

I have added module name on a template file as per Magento standard coding format.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

I have changed all Magneto Backend module template. so You can check after login on Magento Dashboard.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda
Copy link
Contributor

Can you please edit the PR and complete the template? This is not going to be processed until then. Thanks!

@gelanivishal
Copy link
Contributor Author

@miguelbalparda I'm not getting you. Can you please elaborate?

@miguelbalparda
Copy link
Contributor

There is a template you didn't complete when you submitted the PR.

Description

Fixed set template syntax in block file
Fixed Issues (if relevant)

N/A
Manual testing scenarios

N/A

Please edit the description and fill in the details. Thanks!

@miguelbalparda
Copy link
Contributor

@vgelani please remember to fill the template so we can proceed with the merge. Thanks!

@gelanivishal
Copy link
Contributor Author

@miguelbalparda I have updated. Let me know if you want to change or update anything.
Thank you

@magento-engcom-team magento-engcom-team merged commit 1d1e118 into magento:2.2-develop May 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vgelani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants