Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] magento/magento2#:11155 Refactor ConfigGenerator to replace/set crypt key instead of append #13630

Merged
merged 1 commit into from
Mar 4, 2018

Conversation

nmalevanec
Copy link
Contributor

@nmalevanec nmalevanec commented Feb 13, 2018

Original Pull Request

#11155 by @renttek)

General

Fix the command "setup:config:set --key=..." to replace existing crypt key instead of append it.

Description

Originally a call so "bin/magento setup:config:set --key='foobar'" did
not replace the crypt key, but append it with a newline.

This does not only "break" handling of values, encryptwed with the old
key, but also don't allow use of new key, because the new key is
composed of the old one, a newline and the new one.

Fixed Issues (if relevant)

  1. setup:config:set --key append instead of replace #11089: setup:config:set --key append instead of replace

Manual testing scenarios

  1. Install Magento & get sure, that there is a crypt key defined in env.php
  2. Call "bin/magento setup:config:set --key="
  3. New crypt key in env.php should be your new key, instead of "\n"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 1, 2018
@magento-engcom-team magento-engcom-team merged commit 88a90f8 into magento:2.3-develop Mar 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Mar 4, 2018
…rator to replace/set crypt key instead of append #13630
@nmalevanec nmalevanec deleted the forwardport-pull-11155 branch August 21, 2018 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants