Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization: magento/module-tax is_null change to strict comparison #13170

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Optimization: magento/module-tax is_null change to strict comparison #13170

merged 1 commit into from
Jan 16, 2018

Conversation

coderimus
Copy link
Contributor

@coderimus coderimus commented Jan 14, 2018

Hello,
This is the one of the optimization PR linked with the is_null() change. I decided to do them per module just to avoid any mistake during delivery and review.
Best regards,
Alex

Description

Micro-optimizations for Magento\Tax
Magento2 has next sniff MicroOptimizations It checks next: is_null must be avoided. Use strict comparison instead.
Some classes are under // @codingStandardsIgnoreFile such as Magento\Tax module models and cannot be checked during static tests. In this PR I replaced is_null with strict comparison only for models in Magento\Tax module.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ihor-sviziev ihor-sviziev self-assigned this Jan 14, 2018
@ishakhsuvarov ishakhsuvarov self-assigned this Jan 15, 2018
@ishakhsuvarov ishakhsuvarov added this to the January 2018 milestone Jan 15, 2018
@magento-team magento-team merged commit 50238bb into magento:2.2-develop Jan 16, 2018
magento-team pushed a commit that referenced this pull request Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants