Optimization: magento/module-tax is_null change to strict comparison #13170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is the one of the optimization PR linked with the
is_null()
change. I decided to do them per module just to avoid any mistake during delivery and review.Best regards,
Alex
Description
Micro-optimizations for Magento\Tax
Magento2 has next sniff MicroOptimizations It checks next:
is_null must be avoided. Use strict comparison instead.
Some classes are under
// @codingStandardsIgnoreFile
such as Magento\Tax module models and cannot be checked during static tests. In this PR I replacedis_null
with strict comparison only for models in Magento\Tax module.Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A
Contribution checklist