Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved Checkout-Payment-Wrong promo code cancelled issue #13030

Merged
merged 4 commits into from
Jan 10, 2018
Merged

Resolved Checkout-Payment-Wrong promo code cancelled issue #13030

merged 4 commits into from
Jan 10, 2018

Conversation

chiragp-wagento
Copy link

Wrong promo code cancelled issue on Checkout > Payment and Cart page.

Description

Disabled the input box for promo code when promo code is already applied to the site.

Manual testing scenarios

  1. Create one cart price rule from admin side Marketing > Cart Price Rules and use Specific Coupon for Coupon field or use any existing promo code to use in front side.
  2. Add any product in cart
  3. Apply promo code from cart page
  4. Once promo code is applied then input box for add promo code will be disabled, we need to cancel the existing applied promo code then we apply new one.
  5. Same with checkout page, apply any promo code on checkout page.

Expected result

Promo code input box will be disabled once we apply any promo code.

Actual result

Promo code removed

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 7, 2018

CLA assistant check
All committers have signed the CLA.

@dmanners dmanners added the mm18in label Jan 7, 2018
@@ -22,12 +22,23 @@
<span data-bind="i18n: 'Enter discount code'"></span>
</label>
<div class="control">
<!-- ko ifnot: isApplied() -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole condition may be simplified to something like data-bind="attr:{disabled:isApplied()}".
This will allow to avoid copy-pasting the code

@ishakhsuvarov ishakhsuvarov self-assigned this Jan 7, 2018
@ishakhsuvarov ishakhsuvarov added this to the January 2018 milestone Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants