Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download link does not get rendered in invoice email #11024

Merged
merged 2 commits into from
Oct 19, 2017

Conversation

jaykobi
Copy link

@jaykobi jaykobi commented Sep 25, 2017

Download link does not get rendered in invoice email

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 25, 2017

CLA assistant check
All committers have signed the CLA.

@miguelbalparda
Copy link
Contributor

This seems to be breaking some tests, can you check them and report back?

@miguelbalparda
Copy link
Contributor

Also, could you please edit this PR description to use the correct template?

@dmanners
Copy link
Contributor

dmanners commented Oct 5, 2017

@skymeissner it looks like the unit test is failing as you have updated the method called in the getLinks method and as such you will also need to update the method mocked in the Magento\Downloadable\Test\Unit\Block\Sales\Order\Email\Items\DownloadableTest class. Are you able to update this so we can progress with the pull request?

@fooman fooman self-assigned this Oct 15, 2017
@fooman fooman added this to the October 2017 milestone Oct 15, 2017
@magento-team magento-team merged commit cdd854b into magento:develop Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants