Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the return type in the tax rate ajax controllers to be correct #10420

Merged

Conversation

dmanners
Copy link
Contributor

@dmanners dmanners commented Aug 3, 2017

Description

While working on the Json controllers task I notices a couple of the Ajax controllers in Magento Tax had the wrong or no return type or did not show that they actually could throw an exception with the call to $this->resultFactory->create

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Aug 3, 2017
@ishakhsuvarov ishakhsuvarov added this to the August 2017 milestone Aug 3, 2017
@magento-team magento-team merged commit d27cf63 into magento:develop Aug 4, 2017
magento-team pushed a commit that referenced this pull request Aug 4, 2017
@dmanners dmanners deleted the update-json-controller-returns branch December 19, 2017 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants