Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced price export file is empty #24722

Closed
pavru opened this issue Sep 25, 2019 · 6 comments
Closed

Advanced price export file is empty #24722

pavru opened this issue Sep 25, 2019 · 6 comments
Assignees
Labels
Component: AdvancedPricingImportExport Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@pavru
Copy link

pavru commented Sep 25, 2019

Preconditions (*)

  1. Magento 2.3.x
  2. Create a lot of products more than export page size in my case it's 5000 products.
  3. Assign tier price to a product with the lowest ID.

Steps to reproduce (*)

  1. Try to export advanced price.

Expected result (*)

  1. CSV file with one row of tier price should be created.

Actual result (*)

  1. Export error, the file is not created.

Possible problem.

Probably the bug is in vendor\magento\module-advanced-pricing-import-export\Model\Export\AdvancedPricing.php file.
To find the number of products the collection is loaded with ordering by "has_options" column.

            $entityCollection = $this->_getEntityCollection(true);
            $entityCollection->setOrder('has_options', 'asc');
            $entityCollection->setStoreId(Store::DEFAULT_STORE_ID);
            $this->_prepareEntityCollection($entityCollection);
            $this->paginateCollection($page, $this->getItemsPerPage());
            if ($entityCollection->count() == 0) {
                break;
            }

Then the same collection is used to get data for exporting with ordering by "entity_id" column without cleaning. As a result different set of product is loaded for default store id and the next store id.

            $collection->setOrder('entity_id', 'asc');
            $this->_prepareEntityCollection($collection);
            $collection->setStoreId($storeId);
            $collection->load();
            foreach ($collection as $itemId => $item) {
                $data[$itemId][$storeId] = $item;
            }
            $collection->clear();
@m2-assistant
Copy link

m2-assistant bot commented Sep 25, 2019

Hi @pavru. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@pavru do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 25, 2019
@pavru
Copy link
Author

pavru commented Sep 25, 2019

Workaround patch:

diff --git ../vendor/magento/module-advanced-pricing-import-export/Model/Export/AdvancedPricing.php ../vendor/magento/module-advanced-pricing-import-export/Model/Export/AdvancedPricing.php
index fda6ae95301..04f719dc8d4 100644
--- ../vendor/magento/module-advanced-pricing-import-export/Model/Export/AdvancedPricing.php
+++ ../vendor/magento/module-advanced-pricing-import-export/Model/Export/AdvancedPricing.php
@@ -211,6 +211,7 @@ class AdvancedPricing extends \Magento\CatalogImportExport\Model\Export\Product
             if ($entityCollection->count() == 0) {
                 break;
             }
+            $entityCollection->clear();
             $exportData = $this->getExportData();
             foreach ($exportData as $dataRow) {
                 $writer->writeRow($dataRow);

@engcom-Charlie engcom-Charlie self-assigned this Sep 25, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 25, 2019

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Charlie engcom-Charlie added Component: AdvancedPricingImportExport Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 26, 2019
@ghost ghost unassigned engcom-Charlie Sep 26, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 26, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-20483 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@mahesh-rajawat mahesh-rajawat self-assigned this Oct 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 1, 2019

Hi @maheshWebkul721. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


mahesh-rajawat added a commit to mahesh-rajawat/magento2 that referenced this issue Oct 2, 2019
@magento-engcom-team
Copy link
Contributor

Hi @pavru. Thank you for your report.
The issue has been fixed in #24831 by @maheshWebkul721 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.4 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Oct 8, 2019
magento-engcom-team added a commit that referenced this issue Oct 8, 2019
 - Merge Pull Request #24831 from maheshWebkul721/magento2:fixed-24722
 - Merged commits:
   1. 0c102bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: AdvancedPricingImportExport Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants