-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Manual Mode indexing #171
Comments
Hello Colin. Can you reach out to me at peter(at) magento.com? I'd like to discuss this in more details |
Hi. Could you please elaborate on #2? Do you mean that we should invalidate FPC entry for given page (product X) only after product X is already indexed? Our current approach was to use cache even the previous version and then refresh cache. |
The 2nd point was not necessarily specifically related to FPC, but to cache in general (e.g. block_html). After (1) is implemented, if proper block rendering is dependent on indexes, then if indexes are rebuilt in the background but cache is cleared in the foreground (i.e. _afterSave method calls cleanCache($this->getTagIds())) then this would allow a situation where the cache is cleared and then re-populated before the background indexer completes reindexing which would mean you basically just refreshed stale cache entries. So, one solution might be to store the list of tags to be cleared in the indexer event so that the background indexer can clear the tags after the event is processed. |
This would require a Jobq implementation like ZendJobq or Gearman which is not available everywhere. Imho this should be implemented as optional feature using a Jobq-Implementation only when it is available. The user should be able to specify a Jobq strategy in the system configuration. I've implemented a Jobq module for Magento 1.x which supports ZendJobq, Gearman and a cli/cron based setup maybe I can port this to magento 2 core. When implementing background jobs, you need to be aware of certain circumstances.
|
The indexer tables are already pretty close to acting as a job queue, just not a general purpose one. I think a general purpose job queue in Magento would be great, no almost a necessity.. |
These changes would never see CE anyway so closing.. |
…ck-sales-channel Stock Removal. Throw an exception and allow to delete just unassigned stocks
Hi @colinmollenhour. Thank you for your report. The fix will be available with the upcoming 2.4.0 release. |
One of my dreams is for Magento to be able to:
The text was updated successfully, but these errors were encountered: