Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart. #12081

jhruehl · 2017-11-07T15:39:35Z

Since updating one of our stores to Magento 2.2 the translations for 'Item in Cart' are not compiled into the var/view_processed/pub/static/frontend/{Magento-Theme}/{language code}/js-translation.json files, though the translations for 'Items in Cart' are correctly loaded.

Preconditions

Magento 2.2.0
PHP 7.0 and 7.1 (different local setups and different testservers)
MySQL 5.5.5-10.1.23-MariaDB

Steps to reproduce

Have a store view in another language than en_US.
Set a translation for 'Item in Cart' for that language.
Open your store with the store view according to language, where you expect the translation to be done.
Add exactly one item to your cart.
Open the mini cart.

Expected result

'Item to Cart' translated to store view given language.

Actual result

'Item to Cart' is not translated.

Details

So the problem or at least a symptom of the problem seems to be in the 'vendor/magento/module-checkout/view/frontend/web/template/minicart/content.html' template. Strangely not all 'translate'-nodes are triggering the Magento 2 Content Compiler to actually set the requested translations into the theme and language given js-translations.json files.
Though the lines
33 - <translate args="'Item in Cart'" if="getCartLineItemsCount() === 1"/>
and
34 - <translate args="'Items in Cart'" if="getCartLineItemsCount() > 1"/>
are almost completely identical, the translations for 'Items in Cart' are loaded, but not for 'Item in Cart'.

The text was updated successfully, but these errors were encountered:

magento-engcom-team · 2017-11-08T11:18:22Z

@jhruehl, thank you for your report.
We've created internal ticket(s) MAGETWO-83448 to track progress on the issue.

avestique · 2017-11-23T10:17:43Z

The problem is that there was not js translation before <translate> tag.

I solved it temporary by overriding template
src/vendor/magento/module-checkout/view/frontend/web/template/minicart/content.html

and add there js translation:

<div class="items-total"> to 
<div class="items-total" data-translate-hidden="attr: { item_in_cart: $t('Item in Cart') }"

you can use any name for attribute here.

This solution works for me.

emmathepossum · 2017-11-30T14:58:33Z

@avestique Unfortunately your solution doesn't work for me.

The translation also doesn't work in the checkout. The code is the same:

magento/module-checkout/view/frontend/web/template/summary/cart-items.html

<strong role="heading">
    <translate args="maxCartItemsToDisplay" if="maxCartItemsToDisplay < getCartLineItemsCount()"/>
    <translate args="'of'" if="maxCartItemsToDisplay < getCartLineItemsCount()"/>
    <span data-bind="text: getCartLineItemsCount()"></span>
    <translate args="'Item in Cart'" if="getCartLineItemsCount() === 1"/>
    <translate args="'Items in Cart'" if="getCartLineItemsCount() > 1"/>
</strong>

jhruehl · 2017-11-30T15:21:46Z

Ok. A quite easy temporary solution, to get the missing js translations actually compiled and loaded, is to create an extension, which adds a basic js file to the head via view/frontend/layout/default.xml:
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd"> <head> <script src="Blub_LoadMissingJsTranslations::js/missing-translations.js"/> </head> </page>.

Then just add view/frontend/js/missing-translations.js:
require([ 'mage/translate' ], function ($t) { // put missing js translations here, e.g. // $t("some text to be translated"); });

emmathepossum · 2017-11-30T15:39:25Z

@jhruehl This doesn't work either. The js is loading, but it's not being translated.

jhruehl · 2017-11-30T15:51:42Z

Actually the js-file in the extension is just a mock. We overwrite it in our default theme via design/frontend/[theme]/default/[vendor_extension]/web/js/missing-translations.js:
require([ 'mage/translate' ], function ($t) { // put missing js translations here, e.g. // $t("some text to be translated"); $t('Item in Cart'); });

But it could also be that you have to delete your local browser storage. One time I lost hours, because phrases in one js file weren't translated, though everything was correct.

The problem at that time was my browser having cached an old js translation file and didn't reload it automatically.

Opening your page in a private browser window should suffice, if the browser cache/storage is now the problem.

emmathepossum · 2017-11-30T15:57:31Z

Browser Cache wasn't the issue. I added the 'Item in Cart' translation manually to the js-translation.json file for now.

Triloworld · 2017-12-14T10:34:23Z

Found core problem of this issue on site.
Thx @jhruehl for tip but won't solve it.
Step to reproduce problem:
Be sure that you have translation in "mage-translation-storage" of "My Cart" in this example.

Add

app/design/frontend/[theme]/default/web/js/missing-translations.js

require([ 'ko','mage/translate' ], function ($t) {
    console.log($t("My Cart"));
});

This is in minicart text which don't translate correct.
After site load, check console. This text isn't translate.
Next, run in console the same code:

require([ 'ko','mage/translate' ], function ($t) {
    console.log($t("My Cart"));
});

Text is translate.

Even more. This content of script loading fine:

require([ 'mage/translate','domReady!' ], function ($t) {
    console.log($t("My Cart")); // Dom ready so this take little more time. This can be just everything to change order/slow down loading of site.
});

Bug is in order of script loading or some ajax request that don't return value correct.
Add breakpoint in: pub/static/.../mage/translate.js to see what happens

Triloworld · 2017-12-14T15:48:58Z

I have one more think. It is connected to this one.

After digging in backend found this one file:

vendor/magento/framework/Translate.php

protected function _getFileData($file)
 {
     $data = [];
     if ($this->directory->isExist($this->directory->getRelativePath($file))) {
         $this->_csvParser->setDelimiter(',');
         $data = $this->_csvParser->getDataPairs($file);
     }
     return $data;
 }

Translate does not take into account different modules. Same string and other scope are just considered to be equal.

I provide example to show problem.

Click to expand test code showing problem - run in php online to check result

<?php

//TEST FOR STRING: "Show"

$data = [];
$keyIndex = 0;
$valueIndex = 1;

$csvData = array (
  0 => 
  array (
    0 => 'Show',
    1 => 'ABC:',
    2 => 'module',
    3 => 'Magento_Catalog',
  ),
  1 => 
  array (
    0 => 'Show',
    1 => 'CBA',
    2 => 'module',
    3 => 'Magento_Checkout',
  )
);

foreach ($csvData as $rowData) {
    
    
    if (isset($rowData[$keyIndex])) {
      
        $data[$rowData[$keyIndex]] = isset($rowData[$valueIndex]) ? $rowData[$valueIndex] : null;
    
    } else {
        echo "Else:
        ";
        var_dump(count($csvData));
        var_dump(count($data));
    } 
}

echo "Final:
";
var_dump(count($csvData)); //GET 2
var_dump(count($data)); //GET ONLY 1

Userr017 · 2017-12-21T13:58:13Z

I added file cart-items.html and this code. Now "Item in Cart" translating for different language works.

<div class="title" data-role="title">
    <strong role="heading"><span data-bind="text: getItemsQty()"></span>
        <!-- ko if: getItemsQty() == 1 -->
        <!-- ko i18n: 'Item in Cart' --><!-- /ko -->
        <!-- /ko -->
        <!-- ko if: getItemsQty() > 1 -->
        <!-- ko i18n: 'Items in Cart' --><!-- /ko -->
        <!-- /ko -->
    </strong>
</div>

app/design/frontend/theme/theme/Magento_Checkout/web/template/cart-items.html

rsulym · 2017-12-23T23:21:39Z

hi, any of solutions provided above doesnt work for me (M2.2.2). does anybody have working solution? thanks in advance!

Tonvdpol · 2017-12-29T15:03:03Z

I think I have a workaround.

Create the directory:

app/design/frontend/your_vendor/your_theme/Magento_Checkout/templates

Copy cart.phtml to this directory from:

/vendor/magento/module-checkout/view/frontend/templates/cart.phtml

Add this code anywhere in cart.phtml:
$dummy = __('Item in Cart');

Now regenerate the static files.

Side note: any phtml will do. Apparently Magento 2 scans all phtml files for __('...') and adds these to js-translation.json

torhoehn · 2018-01-03T09:36:54Z

@magento-engcom-team Is there any progress on MAGETWO-83448?

emmathepossum · 2018-01-10T09:46:09Z

@rsulym Try @Userr017 solution again, but with this path:
app/design/frontend/theme/theme/Magento_Checkout/web/template/summary/cart-items.html

Amadeco · 2018-01-11T09:09:23Z

@magento-engcom-team Is there any progress on MAGETWO-83448?

maxxeh1 · 2018-02-05T10:44:38Z

In magento 2.2 (you can probably do this in other versions as well) you can add data-bind="i18n: 'Item in Cart'" to
Line 32 in module-checkout/view/frontend/web/template/minicart/content.html
Of course over-ride this file. This then adds the translation to js-translation.json to also translate the Checkout

mattijv · 2018-02-06T13:13:50Z

The reason why some strings are not translated is because they are by default only in html files in tags like

<translate args="'Item in Cart'" if="getCartLineItemsCount() === 1"/>

The Magento Translation module has four different patterns it uses to detect translatable phrases. Only the translations for strings matching these patterns are translated into the js-translation.json. You can see the patterns in Magento/Translation/etc/di.xml. Unfortunately none of those patterns match the translate args tags.

To fix this without needing to explicitly call for a translation on all the missing phrases, you can add the following lines into pretty much any module's di.xml:

    <type name="Magento\Translation\Model\Js\Config">
        <arguments>
            <argument name="patterns" xsi:type="array">
                <item name="translate_args" xsi:type="string"><![CDATA[~translate args\=("|'|"')([^\'].*?)('"|'|")~]]></item>
            </argument>
        </arguments>
    </type>

This adds a pattern that matches the translate args tags to the translation config.

@magento-engcom-team Suggested fix for the issue is to add the above pattern (or something similar) to the relevant part of Magento/Translation/etc/di.xml.

magento-engcom-team · 2018-02-09T23:13:24Z

Hi @jhruehl. Thank you for your report.
The issue has been fixed in #13528 by @mattijv in 2.2-develop branch
Related commit(s):

9c35c45

The fix will be available with the upcoming 2.2.4 release.

…tions.json #13528 - Merge Pull Request #13528 from mattijv/magento2:2.2-develop - Merged commits: 1. 9c35c45

…tions.json #13528

ghost · 2018-02-15T11:01:57Z

Best,

Not fixed still the same issue.
Just like the mini cart issue, this is still in the magento 2.2.2 version.

Regards, and hoping for solutions.

mattijv · 2018-02-15T11:21:32Z

@koopjesboom

See my comment. Copy the lines of code and add them to any suitable module's di.xml. Then empty the pub/static/frontend folder and run

php bin/magento setup:upgrade;
php bin/magento setup:di:compile;
php bin/magento setup:static-content:deploy {{LANGUAGES}};
php bin/magento cache:flush;

Also clean your browser cache. The minicart should be translated correctly. If not, try the above again but make sure you list the language you want to be translated to first in the third step.

[Backport] Fix for magento#12081: missing translations in the js-translations.json

sidolov · 2018-07-12T15:10:38Z

Hi @jhruehl. Thank you for your report.
The issue has been fixed in #16720 by @sanganinamrata in 2.1-develop branch
Related commit(s):

aa0e0514b167b3e9bd0c8c8ce15b4dcf348b08c9

The fix will be available with the upcoming 2.1.15 release.

…s-translations.json #16720 - Merge Pull Request #16720 from sanganinamrata/magento2:2.1-develop-PR-port-13528 - Merged commits: 1. aa0e051

…s-translations.json #16720

sidolov · 2018-07-21T12:01:27Z

Hi @jhruehl. Thank you for your report.
The issue has been fixed in #16892 by @mage2pratik in 2.3-develop branch
Related commit(s):

18d11f580bc51dd2fba1b082c95cf194cd6c477c

The fix will be available with the upcoming 2.3.0 release.

…e js-translations.json #16892 - Merge Pull Request #16892 from mage2pratik/magento2:2.3-develop-PR-port-13528 - Merged commits: 1. 18d11f5

…e js-translations.json #16892

jhruehl changed the title ~~Magento 2.2.0: Translations for 'Item in Cart' in mini cart missing.~~ Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart. Nov 7, 2017

magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Nov 7, 2017

ghost mentioned this issue Nov 8, 2017

Solution for Magento 2.2.0: Translations for 'Item in Cart' in mini cart missing. #12109

Closed

4 tasks

okorshenko removed 2.2.x labels Dec 14, 2017

mattijv added a commit to mattijv/magento2 that referenced this issue Feb 7, 2018

Fix proposal for magento#12081

9c35c45

mattijv mentioned this issue Feb 7, 2018

Fix for #12081: missing translations in the js-translations.json #13528

Merged

4 tasks

magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 9, 2018

magento-engcom-team closed this as completed Feb 9, 2018

magento-engcom-team pushed a commit that referenced this issue Feb 9, 2018

MAGETWO-87575: Fix for #12081: missing translations in the js-transla…

b23ae19

…tions.json #13528 - Merge Pull Request #13528 from mattijv/magento2:2.2-develop - Merged commits: 1. 9c35c45

magento-engcom-team pushed a commit that referenced this issue Feb 9, 2018

MAGETWO-87575: Fix for #12081: missing translations in the js-transla…

63c8a2a

…tions.json #13528

This was referenced Feb 28, 2018

Magento 2.2.2 CHECKOUT translation Imaginaerum/magento2-language-fr-fr#1138

Closed

Magento 2.2.1 checkout translation not working Imaginaerum/magento2-language-fr-fr#1136

Open

sanganinamrata mentioned this issue Jul 11, 2018

[Backport] Fix for #12081: missing translations in the js-translations.json sanganinamrata/magento2#14

Merged

4 tasks

sanganinamrata pushed a commit to sanganinamrata/magento2 that referenced this issue Jul 11, 2018

Fix proposal for magento#12081

aa0e051

sanganinamrata pushed a commit to sanganinamrata/magento2 that referenced this issue Jul 11, 2018

Fix proposal for magento#12081

fd57a48

sanganinamrata mentioned this issue Jul 11, 2018

[Forwardport] Fix for #12081: missing translations in the js-translations.json sanganinamrata/magento2#15

Merged

4 tasks

sanganinamrata added a commit to sanganinamrata/magento2 that referenced this issue Jul 11, 2018

Merge pull request #14 from sanganinamrata/2.1-develop-PR-port-13528

fbbedd1

[Backport] Fix for magento#12081: missing translations in the js-translations.json

sanganinamrata mentioned this issue Jul 11, 2018

[Backport] Fix for #12081: missing translations in the js-translations.json #16720

Merged

4 tasks

sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jul 12, 2018

magento-engcom-team pushed a commit that referenced this issue Jul 12, 2018

ENGCOM-2292: [Backport] Fix for #12081: missing translations in the j…

b88dcff

…s-translations.json #16720

mage2pratik mentioned this issue Jul 17, 2018

[Forwardport] Fix for #12081: missing translations in the js-translations.json #16892

Merged

4 tasks

sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jul 21, 2018

magento-engcom-team pushed a commit that referenced this issue Jul 21, 2018

ENGCOM-2400: [Forwardport] Fix for #12081: missing translations in th…

8dfd12f

…e js-translations.json #16892

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart. #12081

Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart. #12081

jhruehl commented Nov 7, 2017 •

edited

Loading

magento-engcom-team commented Nov 8, 2017

avestique commented Nov 23, 2017 •

edited

Loading

emmathepossum commented Nov 30, 2017

jhruehl commented Nov 30, 2017 •

edited

Loading

emmathepossum commented Nov 30, 2017

jhruehl commented Nov 30, 2017 •

edited

Loading

emmathepossum commented Nov 30, 2017

Triloworld commented Dec 14, 2017 •

edited

Loading

Triloworld commented Dec 14, 2017 •

edited

Loading

Userr017 commented Dec 21, 2017 •

edited

Loading

rsulym commented Dec 23, 2017

Tonvdpol commented Dec 29, 2017

torhoehn commented Jan 3, 2018

emmathepossum commented Jan 10, 2018

Amadeco commented Jan 11, 2018

maxxeh1 commented Feb 5, 2018

mattijv commented Feb 6, 2018

magento-engcom-team commented Feb 9, 2018

ghost commented Feb 15, 2018

mattijv commented Feb 15, 2018

sidolov commented Jul 12, 2018

sidolov commented Jul 21, 2018

Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart. #12081

Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart. #12081

Comments

jhruehl commented Nov 7, 2017 • edited Loading

Preconditions

Steps to reproduce

Expected result

Actual result

Details

magento-engcom-team commented Nov 8, 2017

avestique commented Nov 23, 2017 • edited Loading

emmathepossum commented Nov 30, 2017

jhruehl commented Nov 30, 2017 • edited Loading

emmathepossum commented Nov 30, 2017

jhruehl commented Nov 30, 2017 • edited Loading

emmathepossum commented Nov 30, 2017

Triloworld commented Dec 14, 2017 • edited Loading

Triloworld commented Dec 14, 2017 • edited Loading

Userr017 commented Dec 21, 2017 • edited Loading

rsulym commented Dec 23, 2017

Tonvdpol commented Dec 29, 2017

torhoehn commented Jan 3, 2018

emmathepossum commented Jan 10, 2018

Amadeco commented Jan 11, 2018

maxxeh1 commented Feb 5, 2018

mattijv commented Feb 6, 2018

magento-engcom-team commented Feb 9, 2018

ghost commented Feb 15, 2018

mattijv commented Feb 15, 2018

sidolov commented Jul 12, 2018

sidolov commented Jul 21, 2018

jhruehl commented Nov 7, 2017 •

edited

Loading

avestique commented Nov 23, 2017 •

edited

Loading

jhruehl commented Nov 30, 2017 •

edited

Loading

jhruehl commented Nov 30, 2017 •

edited

Loading

Triloworld commented Dec 14, 2017 •

edited

Loading

Triloworld commented Dec 14, 2017 •

edited

Loading

Userr017 commented Dec 21, 2017 •

edited

Loading