Merge pull request #3016 from magento-obsessive-owls/MAGETWO-94083-im…

…possible-get-information Impossible get information about static errors on PR
magento · Aug 11, 2018 · 1cb9235 · 1cb9235
2 parents 6116023 + a119df4
commit 1cb9235
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/dev/tests/static/phpunit-all.xml.dist b/dev/tests/static/phpunit-all.xml.dist
@@ -21,6 +21,6 @@
     <php>
         <ini name="date.timezone" value="America/Los_Angeles"/>
         <!-- TESTCODESTYLE_IS_FULL_SCAN - specify if full scan should be performed for test code style test -->
-        <const name="TESTCODESTYLE_IS_FULL_SCAN" value="1"/>
+        <const name="TESTCODESTYLE_IS_FULL_SCAN" value="0"/>
     </php>
 </phpunit>
diff --git a/dev/tests/static/phpunit.xml.dist b/dev/tests/static/phpunit.xml.dist
@@ -31,7 +31,7 @@
     <php>
         <ini name="date.timezone" value="America/Los_Angeles"/>
         <!-- TESTCODESTYLE_IS_FULL_SCAN - specify if full scan should be performed for test code style test -->
-        <const name="TESTCODESTYLE_IS_FULL_SCAN" value="1"/>
+        <const name="TESTCODESTYLE_IS_FULL_SCAN" value="0"/>
         <!-- TESTS_COMPOSER_PATH - specify the path to composer binary, if a relative reference cannot be resolved -->
         <!--<const name="TESTS_COMPOSER_PATH" value="/usr/local/bin/composer"/>-->
     </php>

diff --git a/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php b/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php
@@ -256,10 +256,16 @@ private function getFullWhitelist()
         }
     }
 
+    /**
+     * Test code quality using phpcs
+     */
     public function testCodeStyle()
     {
         $isFullScan = defined('TESTCODESTYLE_IS_FULL_SCAN') && TESTCODESTYLE_IS_FULL_SCAN === '1';
         $reportFile = self::$reportDir . '/phpcs_report.txt';
+        if (!file_exists($reportFile)) {
+            touch($reportFile);
+        }
         $codeSniffer = new CodeSniffer('Magento', $reportFile, new Wrapper());
         $result = $codeSniffer->run($isFullScan ? $this->getFullWhitelist() : self::getWhitelist(['php', 'phtml']));
         $report = file_get_contents($reportFile);
@@ -270,6 +276,9 @@ public function testCodeStyle()
         );
     }
 
+    /**
+     * Test code quality using phpmd
+     */
     public function testCodeMess()
     {
         $reportFile = self::$reportDir . '/phpmd_report.txt';
@@ -298,6 +307,9 @@ public function testCodeMess()
         }
     }
 
+    /**
+     * Test code quality using phpcpd
+     */
     public function testCopyPaste()
     {
         $reportFile = self::$reportDir . '/phpcpd_report.xml';