Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web API XML service tag inspection #577

Merged
merged 11 commits into from
Apr 26, 2021
Merged

Web API XML service tag inspection #577

merged 11 commits into from
Apr 26, 2021

Conversation

VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented Apr 23, 2021 •
edited
Loading

Description (*)
Added inspection to check the service tag attributes in the webapi.xml file.

  • Check whether the class exists.

Screenshot 2021-04-23 at 15 33 33

  • Check whether the method exists.

Screenshot 2021-04-23 at 15 34 02

  • Check whether the method have public access.

Screenshot 2021-04-23 at 15 34 37

Additionally removed deprecated method usage from the MagentoIcons class

@Iamwade Iamwade mentioned this pull request Apr 23, 2021
Merged
4 tasks
@eduard13 eduard13 self-assigned this Apr 26, 2021
eduard13
eduard13 approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great job 👍

@eduard13 eduard13 merged commit c267602 into 4.0.0-develop Apr 26, 2021
@VitaliyBoyko VitaliyBoyko deleted the web-api-checks branch December 16, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

Assignees

@eduard13 eduard13

Labels
Advanced Award: test coverage Partner: Atwix partners-contribution Progress: done QA passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VitaliyBoyko @eduard13 @magento-engcom-team