Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added inspection warning for disabled observer #432

Merged
merged 4 commits into from
Dec 21, 2020
Merged

Added inspection warning for disabled observer #432

merged 4 commits into from
Dec 21, 2020

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Dec 18, 2020 •
edited
Loading

Description

This PR adds

  • inspection warning for disabling of an observer which doesn't exist
  • test coverage

Fixed Issues

  1. Fixes Inspection warning when disabling a nonexistent observer in events.xml #424: Inspection warning when disabling a nonexistent observer in events.xml

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@drpayyne drpayyne changed the title Issue 424 Added inspection warning for disabled observer Dec 18, 2020
@drpayyne drpayyne marked this pull request as draft December 18, 2020 08:53
@drpayyne drpayyne marked this pull request as ready for review December 18, 2020 08:54
@coderimus coderimus self-assigned this Dec 18, 2020
@coderimus coderimus self-requested a review December 18, 2020 17:20
@coderimus coderimus merged commit 695db83 into magento:3.1.0-develop Dec 21, 2020
@coderimus
Copy link
Contributor

Hello @drpayyne ,
Thank you for the provided solution (fix). Well done! Also, thank you for mentioning the achievement: I agree that the special achievement is applicable for this PR. I added it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderimus coderimus coderimus approved these changes

Assignees

@coderimus coderimus

Labels
Award: test coverage Easy Medium Partner: EY partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inspection warning when disabling a nonexistent observer in events.xml
3 participants
@drpayyne @coderimus @magento-engcom-team