Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

414: Added Images support for Copy Magento Path #1020

Merged
merged 1 commit into from
Mar 7, 2022
Merged

414: Added Images support for Copy Magento Path #1020

merged 1 commit into from
Mar 7, 2022

Conversation

doninAtwix
Copy link
Contributor

Description (*)
Added Images support for Copy Magento Path.
Used ImageIO extension support for images.

Screenshot 2022-02-28 at 12 40 36

Screenshot 2022-02-28 at 12 39 04

Screenshot 2022-02-28 at 12 38 47

Screenshot 2022-02-28 at 12 38 31

Screenshot 2022-02-28 at 12 38 06

Screenshot 2022-02-28 at 12 37 42

Screenshot 2022-02-28 at 12 37 27

Fixed Issues (if relevant)

  1. Fixes Additional option for "Copy Path..." action #414

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@Iamwade Iamwade requested review from Iamwade March 1, 2022 14:36
@Iamwade Iamwade assigned Iamwade and unassigned Iamwade Mar 1, 2022
@bohdan-harniuk bohdan-harniuk requested a review from eduard13 March 3, 2022 14:00
@bohdan-harniuk
Copy link
Collaborator

Hello, @eduard13!

This PR is created to finish #559.
Could you please check, if your suggestions were implemented?

Regards,

eduard13
eduard13 approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what I was looking for. Great job 👏

@bohdan-harniuk
Copy link
Collaborator

@eduard13, thank you!

@bohdan-harniuk bohdan-harniuk self-requested a review March 7, 2022 10:04
@bohdan-harniuk bohdan-harniuk self-assigned this Mar 7, 2022
@bohdan-harniuk bohdan-harniuk mentioned this pull request Mar 7, 2022
Closed
4 tasks
bohdan-harniuk
bohdan-harniuk approved these changes Mar 7, 2022
View reviewed changes
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @doninAtwix!

Thank you for your work here!

Regards,

@bohdan-harniuk bohdan-harniuk merged commit e06a65b into magento:4.3.0-develop Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

@bohdan-harniuk bohdan-harniuk bohdan-harniuk approved these changes

@Iamwade Iamwade Awaiting requested review from Iamwade

Assignees

@eduard13 eduard13

@bohdan-harniuk bohdan-harniuk

@Iamwade Iamwade

Labels
Partner: Atwix partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional option for "Copy Path..." action
4 participants
@doninAtwix @bohdan-harniuk @eduard13 @Iamwade