Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symfony dependencies for compatibility with Magento 2.4 OnPrem #80

Closed
wants to merge 2 commits into from

Conversation

viktym
Copy link
Contributor

@viktym viktym commented Oct 1, 2020

Description

Currently is not possible to install magento-cloud-patches and magento/quality-patches on Magento 2.4 OnPrem instance due to Symfony composer dependencies conflicts.

Need to allow ^5.1 for "symfony/config", "symfony/dependency-injection", "symfony/proxy-manager-bridge".

Fixed Issues (if relevant)

MC-38123 Update MCP Symfony dependencies for compatibility with Magento 2.4 OnPrem

Manual testing scenarios

Automated tests should pass.

It's possible to install composer package 'magento/magento-cloud-patches' on local Magento 2.4.0 instance:

2.4.0

  1. composer create-project --repository-url=https://repo.magento.com/ magento/project-enterprise-edition=2.4.0
  2. composer config repositories.mcp git git@github.com:magento-mpi/magento-cloud-patches.git
  3. composer require "magento/magento-cloud-patches=dev-MC-38123 as 1.0.99"
  4. Expected: magento/magento-cloud-patches composer package is installed

2.4.1

  1. composer create-project --repository-url=https://repo.magento.com/ magento/project-enterprise-edition=2.4.1
  2. composer config repositories.mcp git git@github.com:magento-mpi/magento-cloud-patches.git
  3. composer require "magento/magento-cloud-patches=dev-MC-38123 as 1.0.99"
  4. Expected: magento/magento-cloud-patches composer package is installed

Release notes

None

Associated documentation updates

Add link to Magento DevDocs PR or Issue, if needed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request introduces user-facing changes and includes meaningful updates for any required release notes and documentation changes
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

@viktym viktym changed the title Mc 38123 Update MCP Symfony dependencies for compatibility with Magento 2.4 OnPrem Oct 1, 2020
@viktym viktym changed the title Update MCP Symfony dependencies for compatibility with Magento 2.4 OnPrem Update Symfony dependencies for compatibility with Magento 2.4 OnPrem Oct 1, 2020
@viktym viktym requested a review from bbatsche October 1, 2020 19:07
@andriyShevtsov
Copy link
Contributor

https://jira.corp.magento.com/browse/MCLOUD-7076 MCLOUD jira ticket

@andriyShevtsov
Copy link
Contributor

QA approved

@andriyShevtsov andriyShevtsov added the Progress: approved PR/issue status label Oct 5, 2020
@andriyShevtsov andriyShevtsov removed their assignment Oct 5, 2020
@viktym viktym closed this Oct 7, 2020
magento-devops-reposync-svc pushed a commit that referenced this pull request Jun 19, 2023
MCLOUD-10674: Release MCP 1.0.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants