Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Added new nfinset search condition #3741

Merged
merged 3 commits into from
Feb 14, 2019

Conversation

ronak2ram
Copy link
Member

@ronak2ram ronak2ram commented Feb 14, 2019

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

When this pull request is merged, it will show nfinset condition for the search.
Reference Pulls:
magento/magento2#20607
magento/magento2#21123

Additional information

List all affected URLs

@magento-cicd2
Copy link
Contributor

An admin must run tests on this PR before it can be merged.

@jeff-matthews jeff-matthews added xx2.3.1 Magento 2.3.1 changes Technical Updates to the code or processes that alter the technical content of the doc labels Feb 14, 2019
@jeff-matthews
Copy link
Contributor

Thanks @ronak2ram! We don't often receive doc contributions that accompany code contributions, but when we do, we're very grateful.

@ronak2ram
Copy link
Member Author

It's my pleasure @jeff-matthews

Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I corrected the grammar

@keharper keharper merged commit 7104ba8 into magento:2.3.1-integration Feb 14, 2019
@ghost
Copy link

ghost commented Feb 14, 2019

Hi @ronak2ram, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper
Copy link
Contributor

Thanks for the code contribution and doc update, @ronak2ram and Krish TechnoLabs!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x Partner: Krish TechnoLabs partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc xx2.3.1 Magento 2.3.1 changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants