Werkzeug für die aktuell eingestellten Mailvorlagen #19

schnumsel · 2017-03-13T19:46:33Z

Hallo Matthias,

also, vielleicht mal zum drüberschaun. Habe das Modul so erweitert, dass unter System -> Tools ein E-Mail-Preview Tool existiert, mit dem man die aktuellen Mails anschaun kann, also auch solche, die z.B. mit Yireo-E-Mail-Override aus Templates und nicht aus der DB erzeugt werden.

Viele Grüße,

Willi

To be able to deploy it

…lace # Conflicts: # app/code/local/Bodenbelag/Marketplace/Model/Dropship/Vendor/Statement.php # app/code/local/Bodenbelag/Marketplace/Model/DropshipPaypalAdaptive/Adaptive.php # app/code/local/Bodenbelag/Marketplace/Model/Observer.php # app/code/local/Bodenbelag/Marketplace/etc/config.xml Moving additional Templates from bodenbelag/transaction-mails to bodenbelag/theme (using magento-snm/transaction-mails instead)

sprankhub · 2017-03-14T07:06:26Z

composer.json

@@ -1,5 +1,5 @@
 {
-    "name": "magento-hackathon/e-mail-preview",
+    "name": "schnumsel/e-mail-preview",


I think this should still be magento-hackathon.

Of course, your right. I did this, not knowing, i could define another branch to fetch the schnumsel stuff via composer.

sprankhub · 2017-03-14T07:08:55Z

.gitignore

@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi)


This file should be removed.

Well, I like to have .gitignore in order not to accidentially commit .idea folder. How do you guys handle this? Via IDE-Settings?

My PhpStorm project root is never the Git repository itself.

Also helpful: http://stackoverflow.com/questions/5724455/can-i-make-a-user-specific-gitignore-file

Personally I would consider a user specific .gitignore bad practise, who cares about a couple of extra lines in a .gitignore file. Not that there aren't use cases for it, but generally speaking.

@schnumsel The current .gitignore is effectively empty though, might as well not have it.

The .idea folder is in the project root, the extension is usually in a subfolder. Hence, no need for such a .gitignore. Additionally, as said by @edannenberg, it is empty anyway and can/should be removed.

mzeis · 2017-09-02T15:17:06Z

Hi Willi,

thank you for your contribution!

If you still would like this to be merged please can you improve the things mentioned by Simon and push again to your branch so I can have a look?

bambamboole · 2017-09-06T08:52:23Z

@schnumsel It would be really nice if you could improve the things because the feature is super useful!

…orlagen magento-hackathon#19

schnumsel · 2017-09-08T07:12:54Z

Well, there it is. Sorry I did the changes in the master-branch not in the dev-willi-branch. Well finally it is done.
Best regards,
Willi

mzeis

Thank you very much for updating!

I reviewed your PR and found one problem causing the new functionality to break.

Please let's also discuss whether we should implement the open todos marked in the code or remove the comments. As I don't use this extension in any project anymore I might not finish these todos myself. :-)

mzeis · 2017-09-10T12:59:56Z

app/code/community/Hackathon/EmailPreview/etc/config.xml

+                        <method>hackathonEmailpreviewRenderEmailBefore</method>
+                    </hackathon_emailpreview_contact>
+                    <hackathon_emailpreview_admin_password_forgot>
+                        <class>hackathon_emailpreview/mail_type_adminPasswordForgot</class>


This class is missing in the PR, causing a warning (and therefore error in developer mode). Please can you add it?

I'll try to check it up these days, maybe next friday since I have a day off...

mzeis · 2017-09-10T13:01:10Z

app/code/community/Hackathon/EmailPreview/Model/Mail/Type/AdminPasswordEmail.php

+            return $this;
+        }
+
+        //@todo change logic here


What would be necessary to get this todo done (question also applies for the other @todo comments)?

same here. quite a long time, since i changed the code :)

…aktuell eingestellten Mailvorlagen magento-hackathon#19"

…ing, only the reference was wrong) Implemented Oauth and System Errors Mails (got rid of the todos) Removed product alert in favor of the existing product alert price and product alert stock observer classes.

schnumsel · 2017-09-15T21:49:20Z

So hello again,

I promised Friday and I managed it (well 12 Minutes left :)
Hope that's it. Haven't delt a long time with this module..

Best regards,

Willi

mzeis · 2017-09-15T22:15:35Z

Thank you, that's commitment! :-) I will be away for two weeks but I'll do the review afterwards.

mzeis · 2017-10-07T15:24:50Z

Thank you again very much for your contribution! The changes are now in the develop branch.

Had to do some dirty changes to get it working with the dev branch quickly but will clean up a bit before releasing the new version.

schnumsel · 2017-10-09T15:34:06Z

Well, unfortunately the dirty hacks did actually break something. My "Hackathon_EmailPreview_Block_Adminhtml_Email_Preview" is quite different compared to the final one.
I am missing specially the Increment ID Field, no order testing without.
How could we proceed?
Best regards, Willi

mzeis · 2017-10-10T19:53:12Z

I'm sorry about the Increment ID field - I fixed this now in dcb8ac8. The other PR introduced dependencies between fields, hiding the form element.

My "Hackathon_EmailPreview_Block_Adminhtml_Email_Preview" is quite different compared to the final one.

Actually that's not because of the "hack" (the one I meant I already removed), that's because the master branch you branched from was quite different from the dev branch where other PRs had been merged before.

Of course, the goal should be to provide a stable v1.1.0. Even if the code is not perfect existing functionality shouldn't break though of course, that's important.

For a future release, it might make sense to do more refactoring, maybe drop the dependency on PHP 5.3 to allow to profit from new languages feature. As I honestly can't spare much time for this I cannot give a guarantee when I might do that.

schnumsel and others added 7 commits January 17, 2017 10:57

Update composer.json

05b02ed

To be able to deploy it

Prepare tool for Magento email development

f396a75

Reverting to original composer.json

27f0d7d

Coninue

fe5bda6

sprankhub reviewed Mar 14, 2017

View reviewed changes

Changes for Pull Request Werkzeug für die aktuell eingestellten Mailv…

cbd3f9f

…orlagen magento-hackathon#19

mzeis requested changes Sep 10, 2017

View reviewed changes

mzeis self-assigned this Sep 10, 2017

mzeis added the needs update label Sep 10, 2017

schnumsel added 2 commits September 15, 2017 21:26

Finishing missing class and todos for pull request "Werkzeug für die …

96696eb

…aktuell eingestellten Mailvorlagen magento-hackathon#19"

Corrected wrong class reference in config.xml (not the class was miss…

88bac2d

…ing, only the reference was wrong) Implemented Oauth and System Errors Mails (got rid of the todos) Removed product alert in favor of the existing product alert price and product alert stock observer classes.

mzeis removed the needs update label Sep 15, 2017

mzeis approved these changes Oct 7, 2017

View reviewed changes

mzeis changed the base branch from master to dev October 7, 2017 11:37

mzeis mentioned this pull request Oct 7, 2017

Preview templates in files #6

Open

mzeis merged commit 88bac2d into magento-hackathon:dev Oct 7, 2017

mzeis added a commit that referenced this pull request Oct 7, 2017

Make PR #19 compatible with dev branch (in an ugly way for now)

54b2f92

mzeis added this to the 1.1.0 milestone Oct 7, 2017

mzeis added a commit that referenced this pull request Oct 10, 2017

Show missing increment ID field in preview tool (#19)

dcb8ac8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Werkzeug für die aktuell eingestellten Mailvorlagen #19

Werkzeug für die aktuell eingestellten Mailvorlagen #19

schnumsel commented Mar 13, 2017

sprankhub Mar 14, 2017

schnumsel Mar 15, 2017

sprankhub Mar 14, 2017

schnumsel Mar 15, 2017

schmengler Mar 15, 2017

edannenberg Mar 15, 2017

sprankhub Mar 16, 2017

mzeis commented Sep 2, 2017

bambamboole commented Sep 6, 2017

schnumsel commented Sep 8, 2017

mzeis left a comment

mzeis Sep 10, 2017

schnumsel Sep 10, 2017

mzeis Sep 10, 2017

schnumsel Sep 10, 2017

schnumsel commented Sep 15, 2017

mzeis commented Sep 15, 2017

mzeis commented Oct 7, 2017

schnumsel commented Oct 9, 2017

mzeis commented Oct 10, 2017

Werkzeug für die aktuell eingestellten Mailvorlagen #19

Werkzeug für die aktuell eingestellten Mailvorlagen #19

Conversation

schnumsel commented Mar 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mzeis commented Sep 2, 2017

bambamboole commented Sep 6, 2017

schnumsel commented Sep 8, 2017

mzeis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

schnumsel commented Sep 15, 2017

mzeis commented Sep 15, 2017

mzeis commented Oct 7, 2017

schnumsel commented Oct 9, 2017

mzeis commented Oct 10, 2017