Skip to content

Commit

Permalink
chore: Disable storage spec type validation (kubeflow#2285)
Browse files Browse the repository at this point in the history
Due to differences in storage provider support between the
KServe storage initializer and ModelMesh puller, this commit
disables the storage spec type validation. With this enabled,
Isvcs on ModelMesh trying to use the new storage spec with azure or gcs
providers will be blocked by KServe's validation webhook. This
check could potentially be re-enabled once gs/azure storage spec
support is provided in the storage initializer.

Signed-off-by: Paul Van Eck <pvaneck@us.ibm.com>
  • Loading branch information
pvaneck authored Jul 3, 2022
1 parent c75e526 commit deeda68
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/apis/serving/v1beta1/predictor.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,9 @@ func (s *PredictorSpec) GetExtensions() *ComponentExtensionSpec {
func (p *PredictorExtensionSpec) Validate() error {
return utils.FirstNonNilError([]error{
validateStorageURI(p.GetStorageUri()),
validateStorageSpec(p.GetStorageSpec(), p.GetStorageUri()),
// TODO: Re-enable storage spec validation once azure/gcs are supported.
// Enabling this currently prevents those storage types from working with ModelMesh.
// validateStorageSpec(p.GetStorageSpec(), p.GetStorageUri()),
})
}

Expand Down

0 comments on commit deeda68

Please sign in to comment.