forked from kubeflow/pipelines
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix missing alibi key in explainers configmap (kubeflow#439)
* Fix missing alibi key in configmap * Remove hardcode alibi image name * Add alibi explainer default test * Add validation/default tests for explainer * Add alibi explainer container creation test * Fix format * Fix alibiexplainer image registry
- Loading branch information
1 parent
a2efe33
commit 9a38524
Showing
7 changed files
with
230 additions
and
74 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| package v1alpha2 | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "github.com/onsi/gomega" | ||
| "github.com/onsi/gomega/types" | ||
| v1 "k8s.io/api/core/v1" | ||
| "k8s.io/apimachinery/pkg/api/resource" | ||
| "strings" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestAlibiExplainer(t *testing.T) { | ||
| g := gomega.NewGomegaWithT(t) | ||
| allowedAlibiImageVersionsArray := []string{ | ||
| DefaultAlibiExplainerRuntimeVersion, | ||
| } | ||
| allowedAlibiImageVersions := strings.Join(allowedAlibiImageVersionsArray, ", ") | ||
|
|
||
| scenarios := map[string]struct { | ||
| spec AlibiExplainerSpec | ||
| matcher types.GomegaMatcher | ||
| }{ | ||
| "AcceptGoodRuntimeVersion": { | ||
| spec: AlibiExplainerSpec{ | ||
| RuntimeVersion: DefaultAlibiExplainerRuntimeVersion, | ||
| }, | ||
| matcher: gomega.Succeed(), | ||
| }, | ||
| "RejectBadRuntimeVersion": { | ||
| spec: AlibiExplainerSpec{ | ||
| RuntimeVersion: "", | ||
| }, | ||
| matcher: gomega.MatchError(fmt.Sprintf(InvalidAlibiRuntimeVersionError, allowedAlibiImageVersions)), | ||
| }, | ||
| } | ||
|
|
||
| for name, scenario := range scenarios { | ||
| config := &InferenceServicesConfig{ | ||
| Explainers: &ExplainersConfig{ | ||
| AlibiExplainer: ExplainerConfig{ | ||
| ContainerImage: "seldon.io/alibi", | ||
| DefaultImageVersion: "latest", | ||
| AllowedImageVersions: allowedAlibiImageVersionsArray, | ||
| }, | ||
| }, | ||
| } | ||
| g.Expect(scenario.spec.Validate(config)).Should(scenario.matcher, fmt.Sprintf("Testing %s", name)) | ||
| } | ||
| } | ||
|
|
||
| func TestCreateAlibiExplainerContainer(t *testing.T) { | ||
|
|
||
| var requestedResource = v1.ResourceRequirements{ | ||
| Limits: v1.ResourceList{ | ||
| "cpu": resource.Quantity{ | ||
| Format: "100", | ||
| }, | ||
| }, | ||
| Requests: v1.ResourceList{ | ||
| "cpu": resource.Quantity{ | ||
| Format: "90", | ||
| }, | ||
| }, | ||
| } | ||
| config := &InferenceServicesConfig{ | ||
| Explainers: &ExplainersConfig{ | ||
| AlibiExplainer: ExplainerConfig{ | ||
| ContainerImage: "seldon.io/alibi", | ||
| DefaultImageVersion: "latest", | ||
| }, | ||
| }, | ||
| } | ||
| var spec = AlibiExplainerSpec{ | ||
| Type: "Anchor", | ||
| StorageURI: "gs://someUri", | ||
| Resources: requestedResource, | ||
| RuntimeVersion: "0.1.0", | ||
| } | ||
| g := gomega.NewGomegaWithT(t) | ||
|
|
||
| expectedContainer := &v1.Container{ | ||
| Image: "seldon.io/alibi:0.1.0", | ||
| Resources: requestedResource, | ||
| Args: []string{ | ||
| "--model_name", | ||
| "someName", | ||
| "--predictor_host", | ||
| "predictor.svc.cluster.local", | ||
| "--storage_uri", | ||
| "/mnt/models", | ||
| "Anchor", | ||
| }, | ||
| } | ||
|
|
||
| // Test Create with config | ||
| container := spec.CreateExplainerContainer("someName", "predictor.svc.cluster.local", config) | ||
| g.Expect(container).To(gomega.Equal(expectedContainer)) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters