Fix pytorch type comments (kubeflow#208)

magdalenakuhn17 · Jun 30, 2019 · 7d7f108 · 7d7f108
1 parent 817a9ad
commit 7d7f108
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 8 deletions.
diff --git a/config/default/crds/serving_v1alpha1_kfservice.yaml b/config/default/crds/serving_v1alpha1_kfservice.yaml
@@ -68,14 +68,15 @@ spec:
                 pytorch:
                   properties:
                     modelClassName:
-                      description: Name of the model class for PyTorch model
+                      description: Defaults PyTorch model class name to 'PyTorchModel'
                       type: string
                     modelUri:
                       type: string
                     resources:
                       description: Defaults to requests and limits of 1CPU, 2Gb MEM.
                       type: object
                     runtimeVersion:
+                      description: Defaults to latest PyTorch Version
                       type: string
                   required:
                   - modelUri
@@ -162,14 +163,15 @@ spec:
                 pytorch:
                   properties:
                     modelClassName:
-                      description: Defaults to latest PyTorch Version.
+                      description: Defaults PyTorch model class name to 'PyTorchModel'
                       type: string
                     modelUri:
                       type: string
                     resources:
                       description: Defaults to requests and limits of 1CPU, 2Gb MEM.
                       type: object
                     runtimeVersion:
+                      description: Defaults to latest PyTorch Version
                       type: string
                   required:
                   - modelUri

diff --git a/pkg/apis/serving/v1alpha1/kfservice_types.go b/pkg/apis/serving/v1alpha1/kfservice_types.go
@@ -82,13 +82,13 @@ type SKLearnSpec struct {
 
 // PyTorchSpec defines arguments for configuring PyTorch model serving.
 type PyTorchSpec struct {
-	ModelURI       string `json:"modelUri"`
+	ModelURI string `json:"modelUri"`
+	// Defaults PyTorch model class name to 'PyTorchModel'
 	ModelClassName string `json:"modelClassName,omitempty"`
-	// Defaults to  PyTorchModel
+	// Defaults to latest PyTorch Version
 	RuntimeVersion string `json:"runtimeVersion,omitempty"`
-	// Defaults to latest Runtime Version.
-	Resources v1.ResourceRequirements `json:"resources,omitempty"`
 	// Defaults to requests and limits of 1CPU, 2Gb MEM.
+	Resources v1.ResourceRequirements `json:"resources,omitempty"`
 }
 
 // CustomSpec provides a hook for arbitrary container configuration.

diff --git a/pkg/apis/serving/v1alpha1/zz_generated.deepcopy.go b/pkg/apis/serving/v1alpha1/zz_generated.deepcopy.go