Added prefixing http for the fix to work (kubeflow#832)

magdalenakuhn17 · May 19, 2020 · 1dc962b · 1dc962b
1 parent d9c431e
commit 1dc962b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/python/kfserving/kfserving/storage.py b/python/kfserving/kfserving/storage.py
@@ -208,8 +208,8 @@ def _download_local(uri, out_dir=None):
 
     @staticmethod
     def _create_minio_client():
-        # Remove possible http scheme for Minio
-        url = urlparse(os.getenv("AWS_ENDPOINT_URL", "s3.amazonaws.com"))
+        # Adding prefixing "http" in urlparse is necessary for it to be the netloc
+        url = urlparse(os.getenv("AWS_ENDPOINT_URL", "http://s3.amazonaws.com"))
         use_ssl = url.scheme == 'https' if url.scheme else bool(os.getenv("S3_USE_HTTPS", "true"))
         return Minio(url.netloc,
                      access_key=os.getenv("AWS_ACCESS_KEY_ID", ""),