Set ContainerConcurrency to Parallelism (kubeflow#806)

magdalenakuhn17 · May 21, 2020 · 111d2f0 · 111d2f0
1 parent 2e13b6a
commit 111d2f0
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/pkg/controller/inferenceservice/resources/knative/service.go b/pkg/controller/inferenceservice/resources/knative/service.go
@@ -148,7 +148,7 @@ func (c *ServiceBuilder) CreatePredictorService(name string, metadata metav1.Obj
 	if isCanary {
 		endpoint = constants.InferenceServiceCanary
 	}
-
+	concurrency := int64(predictorSpec.Parallelism)
 	service := &knservingv1.Service{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      name,
@@ -170,7 +170,8 @@ func (c *ServiceBuilder) CreatePredictorService(name string, metadata metav1.Obj
 					Spec: knservingv1.RevisionSpec{
 						// Defaulting here since this always shows a diff with nil vs 300s(knative default)
 						// we may need to expose this field in future
-						TimeoutSeconds: &constants.DefaultPredictorTimeout,
+						TimeoutSeconds:       &constants.DefaultPredictorTimeout,
+						ContainerConcurrency: &concurrency,
 						PodSpec: v1.PodSpec{
 							ServiceAccountName: predictorSpec.ServiceAccountName,
 							Containers: []v1.Container{
@@ -219,6 +220,7 @@ func (c *ServiceBuilder) CreateTransformerService(name string, metadata metav1.O
 		endpoint = constants.InferenceServiceCanary
 	}
 
+	concurrency := int64(transformerSpec.Parallelism)
 	service := &knservingv1.Service{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      name,
@@ -240,7 +242,8 @@ func (c *ServiceBuilder) CreateTransformerService(name string, metadata metav1.O
 					Spec: knservingv1.RevisionSpec{
 						// Defaulting here since this always shows a diff with nil vs 300s(knative default)
 						// we may need to expose this field in future
-						TimeoutSeconds: &constants.DefaultTransformerTimeout,
+						TimeoutSeconds:       &constants.DefaultTransformerTimeout,
+						ContainerConcurrency: &concurrency,
 						PodSpec: v1.PodSpec{
 							ServiceAccountName: transformerSpec.ServiceAccountName,
 							Containers: []v1.Container{
@@ -285,6 +288,7 @@ func (c *ServiceBuilder) CreateExplainerService(name string, metadata metav1.Obj
 		addLoggerContainerPort(container)
 	}
 
+	concurrency := int64(explainerSpec.Parallelism)
 	service := &knservingv1.Service{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      name,
@@ -306,6 +310,7 @@ func (c *ServiceBuilder) CreateExplainerService(name string, metadata metav1.Obj
 						// Defaulting here since this always shows a diff with nil vs 300s(knative default)
 						// we may need to expose this field in future
 						TimeoutSeconds: &constants.DefaultExplainerTimeout,
+						ContainerConcurrency: &concurrency,
 						PodSpec: v1.PodSpec{
 							ServiceAccountName: explainerSpec.ServiceAccountName,
 							Containers: []v1.Container{