Skip to content

Commit

Permalink
Fix default tensorflow image (kubeflow#66)
Browse files Browse the repository at this point in the history
* fix default tensorflow image

* Rename to ServingVersion to avoid confusion
  • Loading branch information
yuzisun authored and k8s-ci-robot committed May 6, 2019
1 parent e3e083b commit 0b0f03f
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions pkg/apis/serving/v1alpha1/kfservice_defaults.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import (

// Default Values
var (
DefaultTensorflowVersion = "1.12"
DefaultXGBoostVersion = "1.12"
DefaultScikitLearnVersion = "1.12"
DefaultTensorflowServingVersion = "1.13.0"
DefaultXGBoostServingVersion = "0.1.0"
DefaultScikitLearnServingVersion = "0.1.0"

DefaultMemoryRequests = resource.MustParse("2Gi")
DefaultCPURequests = resource.MustParse("1")
Expand Down Expand Up @@ -38,21 +38,21 @@ func setModelSpecDefaults(modelSpec *ModelSpec) {

func setTensorflowDefaults(tensorflowSpec *TensorflowSpec) {
if tensorflowSpec.RuntimeVersion == "" {
tensorflowSpec.RuntimeVersion = DefaultTensorflowVersion
tensorflowSpec.RuntimeVersion = DefaultTensorflowServingVersion
}
setResourceRequirementDefaults(&tensorflowSpec.Resources)
}

func setXGBoostDefaults(xgBoostSpec *XGBoostSpec) {
if xgBoostSpec.RuntimeVersion == "" {
xgBoostSpec.RuntimeVersion = DefaultXGBoostVersion
xgBoostSpec.RuntimeVersion = DefaultXGBoostServingVersion
}
setResourceRequirementDefaults(&xgBoostSpec.Resources)
}

func setScikitLearnDefaults(scikitLearnSpec *ScikitLearnSpec) {
if scikitLearnSpec.RuntimeVersion == "" {
scikitLearnSpec.RuntimeVersion = DefaultScikitLearnVersion
scikitLearnSpec.RuntimeVersion = DefaultScikitLearnServingVersion
}
setResourceRequirementDefaults(&scikitLearnSpec.Resources)
}
Expand Down

0 comments on commit 0b0f03f

Please sign in to comment.