Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review #34

Merged
merged 14 commits into from
Apr 6, 2017
Merged

Code review #34

merged 14 commits into from
Apr 6, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jun 12, 2016

  • use Disposables
  • use notification for errors
  • add CI configurations (you must activate CI in Travis CI and AppVeyor)
  • add CoffeeLint configuration
  • use Opn (don't reinvent the wheel)
  • works with standard Atom and Nuclide
  • fix keymaps bindings and change to ctrl-shift-q and cmd-shift-q on OSX

Fix #28, #26, #25, #23, #21

@ldez ldez force-pushed the refactor/code-review branch from 024ec22 to 4eb478d Compare June 12, 2016 12:24
@ldez
Copy link
Contributor Author

ldez commented Jul 18, 2016

Any remarks ?

@magbicaleman
Copy link
Owner

@ldez thank you for your contribution. I've only glanced it, but I'll be looking at it soon.

@magbicaleman magbicaleman merged commit 563c31d into magbicaleman:master Apr 6, 2017
@ldez ldez deleted the refactor/code-review branch April 6, 2017 20:39
@ldez
Copy link
Contributor Author

ldez commented Apr 6, 2017

@magbicaleman now you can activate CI with Travis CI and AppVeyor
Can you publish a new version ? (apm publish major)

@magbicaleman
Copy link
Owner

I have Travis CI activated (failed), not yet with AppVeyor. I'm assuming the AppVeyor CI, is to test out the plugin in the windows environment.

magbicaleman pushed a commit that referenced this pull request Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not opens file...
2 participants