README: add engine.swarm.downloadSpeed() and clarify engine.swarm.downloaded #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.swarm.downloaded. This is because you end up downloading more than the totalLength to get the actual file. Possibly because of ignored/invalid chunks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's 2 parts to this pull request. The first one should be straight forward - "Add engine.swarm.downloadSpeed()" to the documentation
The second is a clarification. From my tests,
torrent-streamalways ends up downloading more than thetotalLengthand henceengine.swarm.downloadedisnt a good metric to figure out what's left. In other words, trying to do a "%" byengine.swarm.downloaded/totalLengthalways goes above 100%.