Fix pulling from a custom registry #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which only takes a single argument, rather than two.
Bumps the default Engine API version from 1.15 to 1.21.
vweevers
added a commit
to prebuild/prebuildify-cross
that referenced
this pull request
Jul 31, 2021
vweevers
added a commit
to prebuild/prebuildify-cross
that referenced
this pull request
Aug 1, 2021
vweevers
added a commit
to prebuild/prebuildify-cross
that referenced
this pull request
Aug 1, 2021
Depends on prebuild/docker-images#19. Effectively fixes a critical bug (prebuild/docker-images#17) for dockcross-based images. Those are: - `linux-armv6` - `linux-armv7` - `linux-arm64` - `android-armv7` - `android-arm64` Also pins image versions (to version 1) by default, which is now possible because the images are tagged with version numbers in addition to the `latest` tag. Image descriptions have moved to the prebuild/docker-images repository. Uses a temporary fork of the docker-pull npm package in order to include mafintosh/docker-pull#2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Engine API 1.21 (compare against 1.20), the
POST /images/createroute no longer takes aregistryquery parameter:Instead a custom registry must be provided as part of the
fromImagequery parameter:Without this, pulling fails with a
manifest unknownerror:Strangely, with 1.15 (the default version used here) I get the same error. Which led me to a separate bug, namely that
opts.versionisn't forwarded todocker-remote-api. That's fixed by f9f8ec7. Unfortunately it doesn't fix themanifest unknownerror.So I instead propose to bump the default Engine API version from 1.15 to 1.21 and update query parameters accordingly. That's done in b7b315c.