Wrong name.encodingLength() for "" and "example.com." -> extra, trailing byte #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name.encodingLength()
returns the wrong length (off by one) for""
(empty string) and"example.com."
(absolute, ends in a dot) whereasname.encode()
correctly handles both. Is this by design?name.encodingLength()
handles"example.com"
(doesn't end in a dot) but not""
, and"."
(dot) but not"example.com."
.name.encode()
handles all four cases. The upshot is thatanswer.encode({ name: "", type: "A", data: "1.2.3.4" })
returns one extra, trailing byte. I've only ever observed it return a zero byte, but I guess it could be anything, because it usesBuffer.allocUnsafe()
?This simple commit just adds
""
to the cases thatname.encodingLength()
supports. I'm happy to fix the"example.com."
case in the same commit, if I'm on the right track?