Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numpy2 tmp #2

Closed
wants to merge 22 commits into from
Closed

Numpy2 tmp #2

wants to merge 22 commits into from

Conversation

maffoo
Copy link
Owner

@maffoo maffoo commented Sep 29, 2024

No description provided.

aMarcireau and others added 19 commits August 31, 2024 08:58
@aMarcireau @maffoo
Add feature flags for numpy 1 and 2
39f0b6c 
By default, the extension is compile with support for numpy 1 and 2 (with runtime checks to pick the right binary offset where needed). Features or fields that are specific to a version are hidden by default. Users can opt-out of numpy 1 + numpy 2 by disabling default features and selecting a version. The library panics if the runtime version does not match the compilation version if only one version is selected.
@aMarcireau @maffoo
Remove outdated 1.0 functions, add new 2.0 functions
3b6c0b7 
Essentially a port of https://github.com/numpy/numpy/blob/97356bc6f0d6538389a9eef475d883a0f4024c2a/numpy/_core/include/numpy/npy_2_compat.h
@aMarcireau @maffoo
Use the new "universal" access functions
c2e55f8
@aMarcireau @maffoo
Fix runtime tests
e060735
@aMarcireau @maffoo
Remove feature flags and always check the version at runtime where ap…
31924fb 
…propriate
@aMarcireau @maffoo
Avoid API changes by using self.py()
7f59548
@aMarcireau @maffoo
Fixup
9d7e0a2
@aMarcireau @maffoo
Fix flags for Windows
3777299 
Contributed by @stinodego
@adamreichold @maffoo
Avoid half-open range patterns to appease our MSRV build.
c89932b
@adamreichold @maffoo
Remove residual numpy-1/2 feature usage.
92b0947
@adamreichold @maffoo
Use explicit patterns so exhaustiveness checking works, but avoid ope…
9de97ba 
…n bounds for the MSRV build.
@maffoo
Add ci job to test numpy2 and allow numpy2 in examples
be3ce9b
@maffoo
Make size and buf fields public in npy_static_string
1a93b96
@maffoo
Fixes from @adamreichold review
2882c6a
@maffoo
Simplify impl_api macro
61fb9e0
@maffoo
lint
17eda7f
@maffoo
Fixes from review
abebd0f
@davidhewitt
Apply suggestions from code review
da0807f
@maffoo
Fix dtypes tests to work with numpy 1 or 2
6013343
@maffoo maffoo force-pushed the numpy2-tmp branch 11 times, most recently from 2491f85 to 2392b5f Compare September 30, 2024 00:09
@maffoo maffoo force-pushed the numpy2-tmp branch 8 times, most recently from 5c90352 to 8d0f166 Compare September 30, 2024 04:05
@maffoo maffoo mentioned this pull request Sep 30, 2024
Merged
@maffoo maffoo force-pushed the numpy2-tmp branch 2 times, most recently from ab5d5a9 to 5bfa4c8 Compare September 30, 2024 20:11
@maffoo maffoo force-pushed the numpy2-tmp branch 2 times, most recently from 56e1e69 to 598968e Compare October 3, 2024 18:02
@maffoo maffoo closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maffoo @aMarcireau @adamreichold @davidhewitt